New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added some debug output for the network stack #254
Conversation
Needs review. |
@@ -127,6 +138,15 @@ void sixlowpan_mac_init_802154_long_addr(ieee_802154_long_t *laddr) | |||
laddr->uint8[7] = sixlowpan_mac_get_radio_address(); | |||
} | |||
|
|||
char *sixlowpan_mac_802154_long_addr_to_str(char *addr_str, const ieee_802154_long_t *laddr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this function be static? if yes, please guard this function with #ifdef DEBUG_ENABLED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh by bad this function is exported....don't mind the comment above
Updated. |
Any comments on this? |
@@ -40,6 +40,9 @@ | |||
#include "net_help.h" | |||
|
|||
#define ENABLE_DEBUG (0) | |||
#if ENABLE_DEBUG | |||
#define DEBUG_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to have ENABLE_DEBUG
and DEBUG_ENABLE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ENABLE_DEBUG
gets undefined in debug.h
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ugly and confusing but debug.h undefs ENABLE_DEBUG
, so I need to introduce another variable.
needs rebase |
Rebased. |
the superfluous newline is still in there, but not a show stopper... ACK @OlegHahm this is ready for merge right? |
Removed the newline. |
added some debug output for the network stack
added some debug output for the network stack
tools: show stats between releases
Some more debugging output for nativenet, transceiver and sixlowpan.