Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some debug output for the network stack #254

Merged
merged 1 commit into from Nov 14, 2013

Conversation

OlegHahm
Copy link
Member

Some more debugging output for nativenet, transceiver and sixlowpan.

@OlegHahm
Copy link
Member Author

Needs review.

@@ -127,6 +138,15 @@ void sixlowpan_mac_init_802154_long_addr(ieee_802154_long_t *laddr)
laddr->uint8[7] = sixlowpan_mac_get_radio_address();
}

char *sixlowpan_mac_802154_long_addr_to_str(char *addr_str, const ieee_802154_long_t *laddr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this function be static? if yes, please guard this function with #ifdef DEBUG_ENABLED

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh by bad this function is exported....don't mind the comment above

@OlegHahm
Copy link
Member Author

OlegHahm commented Nov 2, 2013

Updated.

@OlegHahm
Copy link
Member Author

Any comments on this?

@@ -40,6 +40,9 @@
#include "net_help.h"

#define ENABLE_DEBUG (0)
#if ENABLE_DEBUG
#define DEBUG_ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to have ENABLE_DEBUG and DEBUG_ENABLE ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ENABLE_DEBUG gets undefined in debug.h.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ugly and confusing but debug.h undefs ENABLE_DEBUG, so I need to introduce another variable.

@mehlis
Copy link
Contributor

mehlis commented Nov 13, 2013

needs rebase

@OlegHahm
Copy link
Member Author

Rebased.

@mehlis
Copy link
Contributor

mehlis commented Nov 14, 2013

the superfluous newline is still in there, but not a show stopper...

ACK

@OlegHahm this is ready for merge right?

@OlegHahm
Copy link
Member Author

Removed the newline.

OlegHahm added a commit that referenced this pull request Nov 14, 2013
added some debug output for the network stack
@OlegHahm OlegHahm merged commit 99ca619 into RIOT-OS:master Nov 14, 2013
@OlegHahm OlegHahm deleted the network_debug branch November 14, 2013 09:46
thomaseichinger pushed a commit to thomaseichinger/RIOT that referenced this pull request Dec 9, 2013
added some debug output for the network stack
eduazocar pushed a commit to eduazocar/RIOT that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants