gnrc/netif: fix source address selection for non-matching prefixes #8536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 6724 ch. 5 rule 8, the source address candidate with the longest matching prefix has to be selected. The current implementation discards source addresses that have no matching prefix (`match = 0`) which is perfectly fine for any global address.
smlng
added
Type: enhancement
miri64
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
According to RFC 6724 ch. 5 rule 8, the source address candidate with the longest matching prefix has to be selected. The current implementation discards source addresses that have no matching prefix (
match = 0) which is perfectly fine for any global destination address.Problem solved
It wasn't possible for a node to communicate via
gnrc_border_routerto the outside world, the node would send packets erroneously with its local address as source address. The BR would then discard the packets because it isn't supposed to forward such packets.