Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_sock: make sock compilable with gnrc_neterr #8584

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@miri64
Copy link
Member

commented Feb 17, 2018

gnrc_sock currently does not compile with gnrc_neterr included, since
both msg_try_receive() and msg_try_send() expect a pointer to a
msg_t, not a msg_t.

To test, just compile an application using gnrc_sock (e.g.
examples/gcoap) with USEMODULE+=gnrc_neterr.

gnrc_sock: make sock compilable with gnrc_neterr
gnrc_sock currently does not compile with `gnrc_neterr` included, since
both `msg_try_receive()` and `msg_try_send()` expect a *pointer* to a
`msg_t`, not a `msg_t`.

To test, just compile an application using `gnrc_sock` (e.g.
`examples/gcoap`) with `USEMODULE+=gnrc_neterr`.
@kb2ma

kb2ma approved these changes Feb 18, 2018

Copy link
Member

left a comment

Symptoms and fix work as described. Tested gcoap example on native and samr21-xpro.

@miri64

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2018

Needs Proxy-ACK. E.g. @smlng?

@bergzand
Copy link
Member

left a comment

Proxy-ACK

@bergzand bergzand merged commit e2b6d6b into RIOT-OS:master Feb 19, 2018

2 checks passed

Murdock The build succeeded. runtime: 5m:43s
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miri64 miri64 deleted the miri64:gnrc_sock/fix/err-report-ptr branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.