Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to configure more variables for IRC server connection (e.g. port, SSL certs, etc.) #113

Open
alcir opened this Issue Jan 9, 2019 · 11 comments

Comments

3 participants
@alcir
Copy link

commented Jan 9, 2019

Summary

Allow user to configure more parts of the IRC server connection (e.g. server port, using self-signed TLS certs, etc.)

Background

IRC servers are a wild world. Everyone can do things a little bit differently or deploy their network in a different way. Most of the current developers run the bot on Freenode, so we haven't thought about other bots as much. However, to make the bot more useful for more people, more options should be opened up for configuration for those who need it.

Details

Implementation should be straightforward. New env variables should be created for the following:

  • IRC server port
  • Allow expired / self-signed TLS certificates

These env variables should be used when negotiating the connection to the IRC server, instead of using hard-coded defaults. For our purposes, we can ship the Freenode defaults in our env.example file.

Outcome

More people can use the bot on a range of different IRC networks, outside of only Freenode


Original comment:

There is a way to specify IRC server port as well as SSL self signed certificate or turning on debug in the .env file or as environment variables?

@alcir alcir changed the title IRC porta and other variables IRC port and other variables Jan 9, 2019

@alcir

This comment has been minimized.

Copy link
Author

commented Jan 9, 2019

I mean the variables you can see in node_modules/irc/lib/irc.js

@jwflory

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@alcir Currently there is not a way to specify these things in Teleirc. This is a good candidate issue for v1.4. We'll review issues for the next sprint once v1.3 is released.

@jwflory jwflory added this to the v1.4 milestone Feb 16, 2019

@jwflory jwflory moved this from Backlog to Next sprint in TeleIRC development Feb 16, 2019

@jwflory jwflory changed the title IRC port and other variables Allow user to configure more variables for IRC server connection (e.g. port, SSL certs, etc.) Mar 3, 2019

@jwflory jwflory self-assigned this Mar 3, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Discussed in 2019-03-02 developer meeting.


This ticket was accepted for the v1.4 sprint.

We agreed this is a high-priority feature because it makes the bot more useful for more people. The implementation should be straightforward. I plan to work on this during the March sprint.

Tjzabel added a commit that referenced this issue Mar 3, 2019

@jwflory jwflory closed this in 1207f99 Mar 3, 2019

TeleIRC development automation moved this from Next sprint to Done Mar 3, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Uhh, actually @Tjzabel meant to close issue 112 with that commit, not this PR. Reopening.

@jwflory jwflory reopened this Mar 3, 2019

TeleIRC development automation moved this from Done to In progress Mar 3, 2019

@jwflory jwflory moved this from In progress to Current sprint in TeleIRC development Mar 3, 2019

@Tjzabel

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@jwflory thanks for the catch!

@jwflory

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

Discussed in 2019-03-30 Teleirc developer meeting.


I plan to do research this week for this ticket. I hope to have an idea of what to include and change for this by the next developer meeting on April 6th. I hope to have a final implementation by April 13th. I left the final week open in case of delays before the end of the v1.4 window on April 20th.

@jwflory jwflory modified the milestones: v1.4, v1.3.1 Apr 6, 2019

@jwflory jwflory moved this from Current sprint to In progress in TeleIRC development Apr 6, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Discussed during 2019-04-06 developer meeting.


I have no major updates yet. Still planning to get this done in the next week.

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

I'm caught up in some of our other work for our new logo and planning our presence at the Imagine RIT festival this month. I suspect I will not have time to work on this before the end of the Spring 2019 semester, but I will try to do what I can.

@jwflory jwflory removed their assignment Apr 10, 2019

@jwflory jwflory moved this from In progress to Current sprint in TeleIRC development Apr 10, 2019

@Tjzabel

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@jwflory thanks for the update! The end of the semester really is a messy time 🤣

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

Discussed in 2019-04-13 Teleirc developer meeting.


As discussed above, I chose to drop this ticket for this sprint since I need more bandwidth to prepare for Imagine RIT at the end of this month.

@nic-hartley finished #19. Next, he is researching this ticket to see if it is simple enough for him to work on before the end of the v1.3.1 sprint on Saturday, April 20th. If it is a quick fix, we'll get it into this release. If not, we'll push back to v1.4.

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Discussed in 2019-04-20 developer meeting. Final developer meeting of the RIT Spring 2019 semester.


This ticket is dropped for the v1.3.1 sprint because we lacked team bandwidth to work on it leading up to university final exams. This ticket may be completed over the summer. More sprints may be planned for summer.

@jwflory jwflory removed this from the v1.3.1 milestone Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.