Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL Improvements #130

Closed
Tjzabel opened this Issue Mar 5, 2019 · 7 comments

Comments

2 participants
@Tjzabel
Copy link
Member

commented Mar 5, 2019

What this is

These are a collection of some quick quality of life improvements that don't necessarily warrant waiting for the 1.4 release. Items may or may not be added.

  • Show filetype IRC-side when sendDocument=false.
  • Insert ZWP into joining + leaving usernames Telegram-side.
  • (Backend) -- Work on handling promise rejections.

@Tjzabel Tjzabel self-assigned this Mar 5, 2019

@Tjzabel Tjzabel added this to Current sprint in TeleIRC development via automation Mar 23, 2019

@jwflory jwflory added this to the v1.4 milestone Mar 23, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

Discussed in 2019-03-30 Teleirc developer meeting.


@Tjzabel has more free time this week to look at this. He is targeting completion for the next developer meeting on Saturday, April 6th.

@Tjzabel

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

As a side note with this issue, we should work on handling promises.

(node:31990) UnhandledPromiseRejectionWarning: ReferenceError: document is not defined
    at TgDocumentHandler._GetDocumentMessage (/home/tim/Code/teleirc/lib/TelegramHandlers/TgDocumentHandler.js:62:13)
    at TgDocumentHandler.RelayDocumentMessage (/home/tim/Code/teleirc/lib/TelegramHandlers/TgDocumentHandler.js:37:28)
(node:31990) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:31990) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@Tjzabel

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

Update

As we have our latest Teleirc Developers Meeting today, here are my updates with this issue:

  • Wasn't actually able to get to this issue as I said I was 🙁
  • I have a few ideas in terms of how I should go with getting this issue completed
    • Since this is a QoL issue, I may continue adding action items throughout the rest of the semester here.
    • Therefore, I am still determining scope and size of this issue.

@jwflory jwflory modified the milestones: v1.4, v1.3.1 Apr 6, 2019

@jwflory jwflory moved this from Current sprint to In progress in TeleIRC development Apr 6, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Discussed during 2019-04-06 developer meeting.


* [ ]  Show filetype IRC-side when `sendDocument=false`.
* [ ]  (Backend) -- Work on handling promise rejections.

@Tjzabel has low bandwidth for the remaining semester. We decided the best strategy is to accomplish each of these one week at a time. For now, Tim will get either one of the two above improvements in as a pull request by the next developer meeting on Saturday, April 13 2019.

@Tjzabel

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2019

Update

I was able to get to inserting ZWP into joining/parting usernames. Due to this, test fails, so I will be adding those tests before adding the short PR.

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Discussed in 2019-04-20 developer meeting. Final developer meeting of the RIT Spring 2019 semester.


@Tjzabel will try to wrap up the ZWP clean-up by Sunday night, April 21. On Monday, April 22, we will cut v1.3.1 either way. Future work will be pushed into the summer or next fall semester.

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

PR #139 brings this issue to a wrap. 🎬 Thanks @Tjzabel for getting this in before the v1.3.1 release deadline! 🎉

@jwflory jwflory closed this Apr 21, 2019

TeleIRC development automation moved this from In progress to Done Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.