Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bold formatting to usernames in message strings on both Telegram and IRC #19

Closed
jwflory opened this Issue Oct 27, 2016 · 10 comments

Comments

6 participants
@jwflory
Copy link
Member

commented Oct 27, 2016

Summary

When using the bridge bot, it would be helpful if usernames were marked up with bold text, to help separate them from the message body on IRC and Telegram.

Analysis

In #8, there was a lot of discussion about how this should be implemented, especially in terms of using pre-existing libraries for markdown. Before completing or coming up with a solution to close this issue, please read through the comments and discussion in #8.

@jwflory jwflory added this to the v1.1.1 milestone Oct 27, 2016

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2016

@repkam09 or @thenaterhood, I know we had a PR that was almost there for this, but do you think it's something we might be able to implement ourselves? This would be a nice feature to make it more clear that the teleirc bot has multiple users behind (e.g. people who reply to messages pinging teleirc).

@repkam09

This comment has been minimized.

Copy link
Member

commented Dec 14, 2016

Is this on the IRC side or the Telegram side, or both? How do you force bold characters in the terminal side? If its as easy as sticking a name in there, or an escape character maybe it could be done earily.

On the Telegram side, there is a formatted text mode that a bot can use instead of just plain text. I looked up how to do it last time this issue was suggested. I would have to read up again on the specifics.

@axk4545

This comment has been minimized.

Copy link
Member

commented Jan 14, 2017

@repkam09 @jflory7 for bolding on the irc side when a message comes through from telegram it should work to put the username string through the bold() method before the full message is assembled and sent through to irc. Not sure going the other way.

@jwflory jwflory modified the milestones: v1.1.1, v1.2 Oct 3, 2017

@ImTheDeveloper

This comment has been minimized.

Copy link

commented Oct 6, 2017

You can use markdown to use bold when sending messages in bold over telegram. I believe using *** works

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2017

@ImTheDeveloper If you'd like to submit a PR for this, that would be awesome, if it's something simple! You'd probably be faster to implement it than me, anyways. Unless @repkam09 or @xforever1313 wanted to take a crack at this.

@dennisroczek

This comment has been minimized.

Copy link

commented Nov 14, 2017

please also add that the IRC comment

\me blabla

gets "highlighted" in another color or so. ;-) at least recognizable in telegram

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2018

If working on editing the message strings between the bridge, it might be helpful to also take a look at #44. It could be possible to do both of these in one go.

@jwflory jwflory modified the milestones: v1.2, v1.2.1 Oct 14, 2018

@jwflory jwflory modified the milestones: v1.2.2, v1.3 Nov 24, 2018

@jwflory jwflory modified the milestones: v1.3, v1.4 Feb 2, 2019

@jwflory jwflory added this to Backlog in TeleIRC development Feb 2, 2019

@nic-hartley

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

I'm going to try to do this as I do #44; it should be possible, though I'm not sure bold is that widely supported on IRC, and I want to make sure that however I do it, it at least looks fine on clients that don't support it.

@jwflory jwflory moved this from Backlog to Next sprint in TeleIRC development Feb 9, 2019

@jwflory jwflory moved this from Next sprint to Current sprint in TeleIRC development Mar 3, 2019

@jwflory jwflory moved this from Current sprint to In progress in TeleIRC development Apr 6, 2019

@jwflory jwflory changed the title Bold usernames on Telegram and IRC Add bold formatting to usernames in message strings on both Telegram and IRC Apr 6, 2019

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

Discussed during 2019-04-06 developer meeting.


@nic-hartley is picking this issue up to work on. If it is as easy as we suspected, he hopes to have a pull request up by Saturday, April 13.

In the meeting, we clarified this is NOT bold highlighting of usernames mentioned in a message, but it is highlighting the message sender's username in their relayed message to the other side. Consider this example:

IRC message: <jwf> Fuego is the best!
Relayed to Telegram: <**jwf**> Fuego is the best!

And vice versa.

@jwflory jwflory closed this in #134 Apr 13, 2019

TeleIRC development automation moved this from In progress to Done Apr 13, 2019

@jwflory jwflory removed this from the v1.4 milestone Apr 13, 2019

@jwflory jwflory added this to the v1.3.1 milestone Apr 13, 2019

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2019

@nic-hartley implemented this in PR #134. Thanks for working on this one Nic! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.