New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-line messages should have each lined prefixed with the userid #53

Closed
michalrud opened this Issue May 14, 2018 · 3 comments

Comments

@michalrud
Copy link
Contributor

michalrud commented May 14, 2018

Currently, when a message with newlines is posted to Telegram, it will be automatically splitted by the bot (well, technically by the underlying irc client library), so when user1 posts a message like this to Telegram (notice the newline):

This is my message.
<user2> I am not very smart

teleirc will post following messages to the IRC channel:

<teleirc>: <user1> This is my message.
<teleirc>: <user2> I am not very smart

Therefore, misleading other IRC users into thinking that user2 admitted his/her own shortcomings.

I will be preparing a PR with a fix. The code is mostly ready, but I would like to test it more before I would consider it ready enough as I didn't actually test it with telegram nor IRC.

michalrud added a commit to michalrud/teleirc that referenced this issue May 14, 2018

Splitting of messages sent to IRC, prepending TG username to each one.
Should fix RITlug#53. Not tested in actual environment yet, so WIP.

@jwflory jwflory added this to the v1.2 milestone Jun 2, 2018

@jwflory

This comment has been minimized.

Copy link
Member

jwflory commented Jun 2, 2018

Thanks for reporting this, @michalrud. I see you have some work in your local branch for this feature. Let us know if you need any help testing the changes out – we have the Teleirc testing group to help us with this purpose. 🙂

@michalrud

This comment has been minimized.

Copy link
Contributor Author

michalrud commented Jun 3, 2018

Testing is the exact thing that's left to be done - I've written some unit tests and in sterile environment of UT it seems to work fine, but it would be great if you can take the code and check it in the testing group :)

@jwflory jwflory modified the milestones: v1.2, v1.2.1 Oct 14, 2018

@jwflory jwflory modified the milestones: v1.2.2, v1.3 Nov 24, 2018

@jwflory jwflory changed the title Splitted messages from Telegram to IRC may cause misunderstandings multi-line messages should have each lined prefixed with the userid Nov 28, 2018

@jwflory

This comment has been minimized.

Copy link
Member

jwflory commented Nov 28, 2018

#95 was a duplicate, but I stole the title of that issue to update this one.

michalrud added a commit to michalrud/teleirc that referenced this issue Dec 5, 2018

Splitting of messages sent to IRC, prepending TG username to each one.
Should fix RITlug#53. Not tested in actual environment yet, so WIP.

michalrud added a commit to michalrud/teleirc that referenced this issue Jan 28, 2019

Splitting of messages sent to IRC, prepending TG username to each one.
Should fix RITlug#53. Not tested in actual environment yet, so WIP.

@jwflory jwflory added this to In progress in Teleirc development Feb 2, 2019

@jwflory jwflory closed this in #102 Feb 8, 2019

Teleirc development automation moved this from In progress to Done Feb 8, 2019

jwflory added a commit that referenced this issue Feb 8, 2019

Splitting of messages sent to IRC, prepending TG username to each one. (
#102)

* Splitting of messages sent to IRC, prepending TG username to each one.

Should fix #53. Not tested in actual environment yet, so WIP.

* Fixed the issue of incompatible interface by adding a simple, string based one as an option.

* Splitting message for IRC moved to Telegram message passing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment