Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Splitting of messages sent to IRC, prepending TG username to each one. #102
Should fix #53. Not tested in live environment.
Also fixed / improved some UTs. Especially hardcoded some config values in tests - some of them would fail if you don't have teleirc configured properly in the first place, what should not be required in UT IMHO.
@michalrud first off, thanks for the PR!
At first glance
I've run a few tests off your branch. Firstly, multiline messages now work! Great work on this!
A little more in-depth
Here is a stack trace of what happens when photos get uploaded to Telegram:
I've given my review. Since the changes I've requested are relatively large changes to how you've done things, I haven't taken much of a look to the unit tests you've created. Once the core functionality is working, I will take my time to go through the tests.
Okay - I know exactly what might have caused it. I'll fix it tomorrow + add an appropriate test. In short - now sendMessageToIrc receives two parameters,
I think I've fixed the issue in the simplest way possible, even if I don't like it that much. IMHO a cleaner way would be to expect all
If you prefer, though, I can rework all
jwflory left a comment
I looked over this and the changes make sense to me. I'm approving this conditionally too on @Tjzabel's review to add
Also, another question: does this close #76 about tests for NickServ authentication?
I didn't test this, but I'm going off of @Tjzabel's successful test too.
Feb 2, 2019
I have one request, and that is just adding a comment (https://github.com/RITlug/teleirc/pull/102/files#r253285164). Everything thing else looks good.
Once that comment is added: Approved!