Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold usernames in message prefixes #134

Merged
merged 3 commits into from Apr 13, 2019

Conversation

3 participants
@nic-hartley
Copy link
Contributor

commented Apr 13, 2019

Resolves #19

Note: There is no officially standardized way to bold things in IRC. However, as far as I can tell, every major client supports wrapping things in 0x02 to make them bold, and the (few, but large) servers I've tested against all seem to handle it fine.

Telegram, on the other hand, does support bold higlighting, with "Markdown" parsing mode. It's not actually Markdown (it uses *foo* instead of **foo**, then _foo_ to represent italics) but they call it that.

nic-hartley and others added some commits Apr 13, 2019

@Tjzabel Tjzabel self-requested a review Apr 13, 2019

@jwflory jwflory added this to In progress in TeleIRC development via automation Apr 13, 2019

@Tjzabel
Copy link
Member

left a comment

Looks good to me!

I tested with several different configurations to make sure everything works, and it does! Bolding comes over to IRC just as expected, and I do like it! Makes it much simpler to tell who is from IRC and who is actually over on Telegram.

@jwflory jwflory removed the needs testing label Apr 13, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

Thanks for reviewing @Tjzabel. 👍 Merging! 🎬

@jwflory jwflory merged commit acc5752 into RITlug:master Apr 13, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

TeleIRC development automation moved this from In progress to Done Apr 13, 2019

@jwflory jwflory added this to the v1.3.1 milestone Apr 13, 2019

@nic-hartley nic-hartley deleted the nic-hartley:19-bold-prefixes branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.