Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete QoL Improvements #139

Merged
merged 1 commit into from Apr 21, 2019

Conversation

2 participants
@Tjzabel
Copy link
Member

commented Apr 21, 2019

What this PR Does

  • Adds ZWP into joining/parting Telegram messages
  • Closes ongoing promise rejection handling
  • Adds filetype IRC side when Telegram file sending set to false

@Tjzabel Tjzabel added the improvement label Apr 21, 2019

@Tjzabel Tjzabel added this to the v1.3.1 milestone Apr 21, 2019

@Tjzabel Tjzabel requested a review from RITlug/teleirc-developers-commit-access Apr 21, 2019

@Tjzabel Tjzabel added this to In progress in TeleIRC development via automation Apr 21, 2019

Complete Quality of Life fixes.
Show filetype, and complete ZWP integration.

@Tjzabel Tjzabel force-pushed the 130/join-part-ZWP branch from 86e05f9 to 4e1b0a1 Apr 21, 2019

@jwflory
Copy link
Member

left a comment

Looks good to me, thanks for getting this in @Tjzabel. 👍 I appreciate that the changes are small – the PR was easy to follow. I did not run a full test, but as I understand @Tjzabel tested these already too. Merging! 🎬

@@ -25,5 +26,8 @@ module.exports.GetFullUserName = function(from) {
return from.first_name;
}

return from.first_name + " (@" + from.username + ")";
// Add ZWP so users with same username across bridge don't ping themselves

This comment has been minimized.

Copy link
@jwflory

jwflory Apr 21, 2019

Member

Thanks for the useful comment, this is the kind of thing we would forget why we did it in two years.

@@ -4,6 +4,7 @@
"description": "A simple Telegram <=> IRC bot",
"main": "teleirc.js",
"scripts": {
"start": "node teleirc.js",

This comment has been minimized.

Copy link
@jwflory

jwflory Apr 21, 2019

Member

On a side note, it could be an interesting side-project for us to package an RPM for TeleIRC. A future sprint idea.

@jwflory jwflory self-assigned this Apr 21, 2019

@jwflory jwflory merged commit e13f8e4 into master Apr 21, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

TeleIRC development automation moved this from In progress to Done Apr 21, 2019

@jwflory jwflory deleted the 130/join-part-ZWP branch Apr 21, 2019

@jwflory jwflory referenced this pull request Apr 21, 2019

Closed

QoL Improvements #130

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.