Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IRC server options #150

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@gnikandrov
Copy link
Contributor

commented Jun 10, 2019

Well, I hope both the title and the code are pretty selfdescriptive. I wanted to use this bot on RusNet, so I had to select different port, but didn't find an option to do so.
Issue #113 seems to be related.

@Tjzabel Tjzabel self-requested a review Jun 10, 2019

@Tjzabel Tjzabel self-assigned this Jun 10, 2019

@Tjzabel Tjzabel added the improvement label Jun 10, 2019

@Tjzabel Tjzabel added this to In progress in TeleIRC development via automation Jun 10, 2019

@Tjzabel

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@gnikandrov thanks for the PR! This is a simple enough change, and everything looks good on my end. TravisCI is failing for some reason on node 10, but I've been unable to replicate the error locally.

It's not a complete blocker on having this PR go through, but I am going to spend some time figuring out why it's failing.

@Tjzabel
Copy link
Member

left a comment

Looks simple enough! 👍

I'm going to approve this PR, but will be holding off on merging it until I can sit down and figure out why TravisCI failed.

@Tjzabel

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Nice! @jwflory I removed the caching from Travis CI, and that seems to have fixed our issue here.

@Tjzabel

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@gnikandrov thanks again for the PR! Merging 👍

@Tjzabel Tjzabel merged commit 43f2679 into RITlug:master Jun 12, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

TeleIRC development automation moved this from In progress to Done Jun 12, 2019

@jwflory

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Thanks for submitting this PR @gnikandrov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.