Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Pin Fedora 30 to Fedora Dockerfile #151

Merged
merged 1 commit into from Jun 23, 2019

Conversation

@jwflory
Copy link
Member

commented Jun 23, 2019

This commit does a couple of things:

  • Pins Fedora Dockerfile to Fedora 30
  • Switches to use registry.fedoraproject.org as the container source
  • Splits packages installed across new lines (for readability)

I built this container locally and it worked. Ideally there needs to be
more work to make this viable (e.g. specifying config values as
environment variables), but that is out of scope for this pull request.

@jwflory jwflory added the improvement label Jun 23, 2019

@jwflory jwflory requested a review from RITlug/teleirc-developers-commit-access Jun 23, 2019

@jwflory jwflory self-assigned this Jun 23, 2019

@jwflory jwflory added this to In progress in TeleIRC development via automation Jun 23, 2019

@jwflory

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

Oh, I also removed the --setopt=deltarpm=false argument as this was causing a strange segfault issue whenever I was building the container. 🤷‍♀ Since there is not a strong use case for us to require using this flag, I figured it was better to remove it.

images: Pin Fedora 30 to Fedora Dockerfile
This commit does a couple of things:

* Pins Fedora Dockerfile to Fedora 30
* Switches to use `registry.fedoraproject.org` as the container source
* Splits packages installed across new lines (for readability)

I built this container locally and it worked. Ideally there needs to be
more work to make this viable (e.g. specifying config values as
environment variables), but that is out of scope for this pull request.

@jwflory jwflory force-pushed the change/fedora-30-container branch from a2ade80 to 551a3c4 Jun 23, 2019

@Tjzabel
Copy link
Member

left a comment

Looks good to me!

@@ -1,4 +1,4 @@
FROM fedora:29
FROM registry.fedoraproject.org/fedora:30

This comment has been minimized.

Copy link
@Tjzabel

Tjzabel Jun 23, 2019

Member

ah, interesting! Nice to pull from the official fedora registry.

libicu-devel \
python \
gcc-c++ \
make \

This comment has been minimized.

Copy link
@Tjzabel

Tjzabel Jun 23, 2019

Member

Thanks for cleaning this up ^.^

@Tjzabel Tjzabel merged commit 36b10ee into master Jun 23, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

TeleIRC development automation moved this from In progress to Done Jun 23, 2019

@Tjzabel Tjzabel deleted the change/fedora-30-container branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.