Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticker handler #283

Merged
merged 3 commits into from Mar 29, 2020
Merged

Sticker handler #283

merged 3 commits into from Mar 29, 2020

Conversation

kennedy
Copy link
Contributor

@kennedy kennedy commented Mar 28, 2020 •
edited

  1. Created the sticker handler
  2. Added a switch statement in the telegram update loop

resolves #249

@kennedy kennedy self-assigned this Mar 28, 2020
kennedy
kennedy commented Mar 28, 2020
View reviewed changes
internal/handlers/telegram/telegram.go
case update.Message.Document != nil:
documentHandler(tg, update.Message)
default:
continue
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and created a switch statement anyway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kennedy kennedy marked this pull request as ready for review March 28, 2020 20:38
Tjzabel
Tjzabel approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Tjzabel Tjzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test out the message functionality. Works well 👍

internal/handlers/telegram/telegram.go
case update.Message.Document != nil:
documentHandler(tg, update.Message)
default:
continue
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Tjzabel Tjzabel added new change Adds new capabilities or functionality Telegram Issues relating to Telegram bridge labels Mar 29, 2020
@Tjzabel Tjzabel added this to In progress in TeleIRC development via automation Mar 29, 2020
@Tjzabel Tjzabel added this to the v2.0.0 milestone Mar 29, 2020
@Tjzabel
Copy link
Member

Tjzabel commented Mar 29, 2020

Since this PR is partially related to the Update handler, I am going to merge this through

@Tjzabel Tjzabel merged commit b243708 into master Mar 29, 2020
TeleIRC development automation moved this from In progress to Done Mar 29, 2020
@Tjzabel Tjzabel deleted the feature/249-sticker-handler branch March 29, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tjzabel Tjzabel Tjzabel approved these changes

@Zedjones Zedjones Awaiting requested review from Zedjones

@kevinassogba kevinassogba Awaiting requested review from kevinassogba

Assignees

@kennedy kennedy

Labels
new change Adds new capabilities or functionality Telegram Issues relating to Telegram bridge
Projects
TeleIRC development
  
Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Create Sticker Handler
2 participants
@kennedy @Tjzabel