Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for Erlang VM stats reporting #3

Merged
merged 5 commits into from May 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

blinkov commented May 24, 2012

No description provided.

Owner

RJ commented May 24, 2012

Hi,
This is a nice addition

Looks like the indentation or tabs/spaces are wrong for lines you've added though, could you make sure it's using spaces like the rest of the file?

Also, you could avoid calling node_key() twice in estatsd_server, just assign it once in that function.

Cheers!
RJ

Contributor

blinkov commented May 24, 2012

Hi, I fixed the things you mentioned, take a look at last commit. Ivan.

RJ added a commit that referenced this pull request May 28, 2012

Merge pull request #3 from blinkov/master
Support for Erlang VM stats reporting

@RJ RJ merged commit 2643d30 into RJ:master May 28, 2012

Owner

RJ commented May 28, 2012

thanks!

elbrujohalcon referenced this pull request in inaka/estatsd Jul 26, 2013

Merge pull request #3 from inaka/elbrujohalcon.eper
Issue tigertext/xmpp#1343: updated eper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment