teach estatsd to support a custom name intead of just node() #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `vm_name` parameter to environment, and store in state - allows collecting uniquely named VM metrics even if epmd is not running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estatsd gets the node name from node() directly. If running epmd and connecting the erlang node to the network isn't possible, this means the default atom nonode@nohost is used.
This patch enables estatsd to use a new application environment VmName, which if present, is used in NodeKey instead. This allows nice, and unique, metric names in graphite without needing epmd and connecting the node to the erlang network.