Skip to content
Browse files

remove -e from echo, which fails on linux

  • Loading branch information...
1 parent f7f67b3 commit f43fdbba962231bd310a81891f3d4ded586aad7a @RJ committed Dec 21, 2009
Showing with 1 addition and 1 deletion.
  1. +1 −1 Makefile
View
2 Makefile
@@ -40,7 +40,7 @@ ebin/playdar.app: src/playdar.app
ESCRIPT="\nmain(_)\n"'-> io:format("default_config()->~p.~n",[file:consult("etc/playdar.conf.example")]),halt(0).'
.default_config.hrl.escript:
- echo -e $(ESCRIPT) > $@
+ echo $(ESCRIPT) > $@
src/playdar_config.erl: include/default_config.hrl
include/default_config.hrl: .default_config.hrl.escript
escript $< > $@

6 comments on commit f43fdbb

@mxcl
mxcl commented on f43fdbb Dec 30, 2009

Stever was insisting -e was required on Linux, so I don't understand anything now.

@mxcl
mxcl commented on f43fdbb Dec 30, 2009

It seems that bash 4 requires -e. However if this is true then previous versions of Bash break with -e.

This seems unlikely, the Bash guys are pretty keen on not breaking scripts.

I'm looking into a better solution here as I feel responsible.

@mim
mim commented on f43fdbb Jan 21, 2010

This just failed for me on linux. It works with the -e under bash 4.0.33(1) and bash 3.2.33(1) and fails without the -e on both.

@mxcl
mxcl commented on f43fdbb Jan 22, 2010

The fix is to use printf rather than echo. I think I pushed it.

@mxcl
mxcl commented on f43fdbb Jan 22, 2010

Yeah I pushed it. RJ please pull my master branch. Thanks. Or at least cherry-pick the fix.

@mim
mim commented on f43fdbb Jan 23, 2010

Cool, thanks. It's working with printf.

Please sign in to comment.
Something went wrong with that request. Please try again.