Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Some results have no score value #26

Closed
jwheare opened this Issue · 2 comments

2 participants

@jwheare

This commit to src/resolver.cpp seems to have broken the score value in get_results json responses.

http://github.com/RJ/playdar/commit/f25562e77d577f3efceaee7b72cf03c5c0bc78bf#L1R466

rip->set_score is now called conditionally, I suspect something's amiss.

Perfect scores always seem to be set, but lower scores often go missing. I had one response with the following result scores:

1.0
0.462
[8 blanks]

Also, I'm noticing a lot more bad results showing up now.

@dougma

yes, that commit contained the problem (zero-scored items were being added to the results). fixed in my fork.

@jwheare

Woot

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.