diff --git a/client/htmls/private/ajax/Settings/CreateProviders.html b/client/htmls/private/ajax/Settings/CreateProviders.html index 3b997d41c..c677ead19 100755 --- a/client/htmls/private/ajax/Settings/CreateProviders.html +++ b/client/htmls/private/ajax/Settings/CreateProviders.html @@ -234,7 +234,7 @@

- +
diff --git a/client/htmls/private/ajax/Settings/providerSync.html b/client/htmls/private/ajax/Settings/providerSync.html index 1cdbbb150..bfb4727f6 100644 --- a/client/htmls/private/ajax/Settings/providerSync.html +++ b/client/htmls/private/ajax/Settings/providerSync.html @@ -1115,12 +1115,12 @@ var tagsProjSelectedVal = $projecttagsList.val(); var tagsenvSelectedVal = $envtagsList.val(); var tagsbgSelectedVal = $bgtagsList.val(); - - if((tagsbgSelectedVal == tagsProjSelectedVal) && (tagsbgSelectedVal == tagsenvSelectedVal)){ + if((tagsbgSelectedVal === tagsProjSelectedVal) + || (tagsbgSelectedVal === tagsenvSelectedVal) + || (tagsProjSelectedVal === tagsenvSelectedVal)){ bootbox.alert("Tag name cannot be same to create catalyst entity mapping"); - return; + return false; } - //Creating the data to Post for Save tags. var tagsData = [{ "catalystEntityType": catalystEntityBgName, @@ -1695,13 +1695,9 @@ "columns": [ {"data": "platformId","orderable" : true }, {"data": "os","orderable" : false }, - {"data": "ip","orderable" : true, - "render": function(data, type, full){ - if(data !== null){ - return data; - }else{ - return full.privateIpAddress; - } + {"data": "","orderable" : true, + "render":function(data, type, full, meta) { + return full.ip !== null ? full.ip:full.privateIpAddress; } }, {"data": "","orderable" : true, @@ -1868,13 +1864,9 @@ "columns": [ {"data": "platformId","orderable" : true }, {"data": "os","orderable" : false }, - {"data": "ip","orderable" : true, - "render": function(data, type, full){ - if(data !== null){ - return data; - }else{ - return full.privateIpAddress; - } + {"data": "","orderable" : true, + "render":function(data, type, full, meta) { + return full.ip !== null ? full.ip:full.privateIpAddress; } }, {"data": "state","orderable" : true }, diff --git a/client/htmls/public/js/awsCapacity.js b/client/htmls/public/js/awsCapacity.js index 771fe231c..5a285514a 100644 --- a/client/htmls/public/js/awsCapacity.js +++ b/client/htmls/public/js/awsCapacity.js @@ -300,12 +300,12 @@ $(document).ready(function() { } }, { - "data": "ip", + "data": "", "orderable": true, "render": function(data, type, full) { - if (data !== null) { + if(full.ip && full.ip !== null){ return data; - } else { + }else{ return full.privateIpAddress; } } @@ -373,14 +373,10 @@ $(document).ready(function() { "data": "os", "orderable": false }, { - "data": "ip", + "data": "", "orderable": true, - "render": function(data, type, full) { - if (data !== null) { - return data; - } else { - return full.privateIpAddress; - } + "render":function(data, type, full, meta) { + return full.ip !== null ? full.ip:full.privateIpAddress; } }, { "data": "state", diff --git a/server/app/model/classes/instance/instance.js b/server/app/model/classes/instance/instance.js index 485885150..0d639e938 100755 --- a/server/app/model/classes/instance/instance.js +++ b/server/app/model/classes/instance/instance.js @@ -2118,23 +2118,18 @@ var InstancesDao = function() { this.updateInstanceStatus = function(instanceId, instance, callback) { var updateObj = {}; + updateObj['instanceState'] = instance.state; + updateObj['subnetId']= instance.subnetId; + updateObj['instanceIP'] = instance.ip; + updateObj['vpcId'] = instance.vpcId; + updateObj['privateIpAddress'] = instance.privateIpAddress; + updateObj['tags'] = instance.tags; if(instance.status && instance.status === 'shutting-down'){ - updateObj['instanceState'] = instance.status; updateObj['isDeleted'] = false; }else if (instance.state === 'terminated') { - updateObj['instanceState'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; updateObj['isDeleted'] = true; - updateObj['tags'] = instance.tags; }else { - updateObj['instanceState'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; updateObj['isDeleted'] = false; - updateObj['tags'] = instance.tags; } Instances.update({ "_id": ObjectId(instanceId) diff --git a/server/app/model/unassigned-instances/unassigned-instances.js b/server/app/model/unassigned-instances/unassigned-instances.js index 4a3075748..3c22fad2e 100644 --- a/server/app/model/unassigned-instances/unassigned-instances.js +++ b/server/app/model/unassigned-instances/unassigned-instances.js @@ -186,20 +186,16 @@ UnassignedInstancesSchema.statics.updateInstance = function updateInstance(param UnassignedInstancesSchema.statics.updateInstanceStatus = function updateInstanceStatus(instanceId,instance,callback) { var updateObj={}; + updateObj['state'] = instance.state; + updateObj['subnetId']= instance.subnetId; + updateObj['ip'] = instance.ip; + updateObj['vpcId'] = instance.vpcId; + updateObj['privateIpAddress'] = instance.privateIpAddress; + updateObj['tags'] = instance.tags; if(instance.state === 'terminated'){ - updateObj['state'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; updateObj['isDeleted'] = true; - updateObj['tags'] = instance.tags; }else{ - updateObj['state'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; updateObj['isDeleted'] = false; - updateObj['tags'] = instance.tags; } UnassignedInstances.update({ "_id": ObjectId(instanceId) diff --git a/server/app/model/unmanaged-instance/unmanaged-instance.js b/server/app/model/unmanaged-instance/unmanaged-instance.js index 5aee11688..4fdda1e63 100644 --- a/server/app/model/unmanaged-instance/unmanaged-instance.js +++ b/server/app/model/unmanaged-instance/unmanaged-instance.js @@ -291,20 +291,16 @@ UnmanagedInstanceSchema.statics.getInstancesByProviderIdOrgIdAndPlatformId = fun UnmanagedInstanceSchema.statics.updateInstanceStatus = function updateInstanceStatus(instanceId,instance,callback) { var updateObj={}; + updateObj['state'] = instance.state; + updateObj['subnetId']= instance.subnetId; + updateObj['ip'] = instance.ip; + updateObj['vpcId'] = instance.vpcId; + updateObj['privateIpAddress'] = instance.privateIpAddress; + updateObj['tags'] = instance.tags; if(instance.state === 'terminated'){ - updateObj['state'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; updateObj['isDeleted'] = true; - updateObj['tags'] = instance.tags; }else{ - updateObj['state'] = instance.state; - updateObj['subnetId']= instance.subnetId; - updateObj['vpcId'] = instance.vpcId; - updateObj['privateIpAddress'] = instance.privateIpAddress; - updateObj['isDeleted'] = false; - updateObj['tags'] = instance.tags; + updateObj['isDeleted'] = false; } UnmanagedInstance.update({ "_id": ObjectId(instanceId)