This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Zoom+pan fix #173
Closed
Zoom+pan fix #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyboard input will now favor the most recent key pressed when opposing direction keys are pressed. This mimics behavior of many FPS games.
using the scroll wheel sets UIS.MouseBehavior to Default, so I added a check to OnMouseWheel that sets MouseBehavior back to LockPosition if the user is panning. Also fixes the bug of releasing MB2 and mouse going into Default while in first person.
This reverts commit af1cc79.
When you scroll, UIS.MouseBehavior will revert to Default. This re-applies the MouseBehavior so that rotating the camera is uninterupted.
|
The bug is fixed, so closing the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for UserInputService bug where scrolling will revert UIS.MouseBehavior to Default. bfcf778 is the only intended commit.