This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Keyboard ControlModule refresh when (Dev)ComputerMovementMode changes #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges This is a fix for the following bug: When changing the ComputerMovementMode or DevComputerMovementMode the Keyboard ControlModule does not update. Currently this bug is only observed when switching to/from the Scriptable DevComputerMovementMode. This does not happen with the Touch ControlModule because it listens for changes to (Dev)ComputerMovementMode. This fix mirrors over the event listening and module refreshing code from the Touch ControlModule to the Keyboard ControlModule in order to remain consistent. This issue was originally pointed out at http://devforum.roblox.com/t/changing-devcomputermovementmode-or-devtouchmovementmode-sometimes-doesnt-activate-instantly/26844
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the following bug:
When changing the ComputerMovementMode or DevComputerMovementMode the Keyboard ControlModule does not update. Currently this bug is only observed when switching to/from the Scriptable DevComputerMovementMode. This has the effect of allowing the player to walk around while DevComputerMovementMode is Scriptable, or not allowing the player to walk around when it is anything else. This does not happen with the Touch ControlModule because it listens for changes to (Dev)ComputerMovementMode.
This fix mirrors over the event listening and module refreshing code from the Touch ControlModule to the Keyboard ControlModule in order to remain consistent between the two.
This issue was originally pointed out on the devforum here.
This also fixes an unrelated duplicate check for the same condition inside Keyboard:Enable.