Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement COMGR V2 support with cmake -DUSE_COMGR=1 guard #1067

Conversation

Projects
None yet
3 participants
@aaronenyeshi
Copy link
Collaborator

commented May 2, 2019

Re-add the previous COMGR changes, but use a macro guard enabled by cmake option -DUSE_COMGR=1.

We can work on fixing PSDB with this guard.

Fix bug in COMGR guard not propagating to hipcc
It seems that the macro USE_COMGR=1 does not propagate down into compiled binaries. So we need to store the USE_COMGR variable into HIP's config, so that using hipcc to build a test will also define this macro.
@aaronenyeshi

This comment has been minimized.

Copy link
Collaborator Author

commented May 2, 2019

@wkwchau I fixed the bug we were seeing with hipcc built binaries not properly defining the macro USE_COMGR as 1.

@scchan
Copy link
Collaborator

left a comment

@aaronenyeshi As discussed, this PR needs to be updated to adapt to changes in PR #1077

@mangupta
Copy link
Collaborator

left a comment

PR #1077 has been merged. Please rebase and resolve the conflicts in this PR.

@aaronenyeshi

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

@wkwchau has resolved the conflicts in his PR #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.