Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hipcc exit code when failing #1117

Merged

Conversation

Projects
None yet
2 participants
@aaronenyeshi
Copy link
Collaborator

commented May 16, 2019

No description provided.

@aaronenyeshi aaronenyeshi requested a review from yxsamliu May 16, 2019

@aaronenyeshi

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

This patch deals with the issue where failed compilations returned a success (exit code 0). Instead we should forward what the compiler returns.

@aaronenyeshi aaronenyeshi requested review from mangupta and gargrahul May 21, 2019

@mangupta mangupta merged commit 49e394c into ROCm-Developer-Tools:master May 24, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@aaronenyeshi aaronenyeshi deleted the aaronenyeshi:fix-exit-code-hipcc branch May 28, 2019

@mkuron mkuron referenced this pull request Jun 6, 2019

Open

Lbgpu node vel #2878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.