[dockerfile] temp reinstall triton==3.6.0 for accuracy#726
Merged
Conversation
gbyu-amd
requested review from
XiaobingSuper,
valarLip,
wuhuikx and
zejunchen-zejun
| rm -f /tmp/triton_pip_show.txt && \ | ||
| "${VENV_PYTHON}" -c "import triton; print(f'triton.__version__ = {triton.__version__}')" | ||
|
|
||
| # unisntall existing triton (acc issue) and install known good version |
Contributor
Author
There was a problem hiding this comment.
Good catch. Updated the comment.
| RUN pip uninstall -y triton && \ | ||
| pip install triton==3.6.0 | ||
| RUN pip show triton || true | ||
|
|
Collaborator
There was a problem hiding this comment.
可以加一些注释，解释为什么放弃前面安装的所有triton版本，选择直截了当安装3.6.0
或者是不是修改兜底建构逻辑 [OOT] Restore base image triton
atom-vllm最后时刻出docker的时候，会restore triton版本，保持和atom docker一致，现在atom-vllm要pin住3.6.0，是不是直接在兜底逻辑里面pin住比较好
Contributor
Author
There was a problem hiding this comment.
Updated comment for background.
valarLip
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist