Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using textures causes "Depth set on single layer image geometry." #113

Closed
ex-rzr opened this issue Feb 1, 2021 · 2 comments
Closed

Using textures causes "Depth set on single layer image geometry." #113

ex-rzr opened this issue Feb 1, 2021 · 2 comments

Comments

@ex-rzr
Copy link

ex-rzr commented Feb 1, 2021

The runtime prints this message to stderr:
https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/master/src/image/hsa_ext_image.cpp#L81

According to HSA specs (http://www.hsafoundation.com/html/Content/Runtime/Topics/03_Extensions/hsa_ext_image_descriptor_t.htm):

height
Height of the image, in components. Only defined if the geometry is 2D or higher.
depth
Depth of the image, in components. Only defined if geometry is HSA_EXT_IMAGE_GEOMETRY_3D. A depth of 0 is same as a depth of 1.
array_size
Number of images in the image array. Only defined if geometry is HSA_EXT_IMAGE_GEOMETRY_1DA, HSA_EXT_IMAGE_GEOMETRY_2DA, or HSA_EXT_IMAGE_GEOMETRY_2DADEPTH.

It seems that ROCR-Runtime and ROCclr both have issues:

  1. ROCR-Runtime checks for depth != 0 incorrectly because "A depth of 0 is same as a depth of 1."

  2. ROCclr sets height, depth, array_size to 1 (https://github.com/ROCm-Developer-Tools/ROCclr/blob/main/device/rocm/rocmemory.cpp#L959)
    However, it's unclear what "defined" means here: 1) incorrect values should be ignored 2) fields can have any values.

@ex-rzr
Copy link
Author

ex-rzr commented Feb 2, 2021

Ok, I'm closing this issue because this is a bug in ROCclr.

@ex-rzr ex-rzr closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants