Adding the docs folder and corresponding sphinx build collateral.#15
Conversation
saadrahim
reviewed
May 2, 2025
Member
There was a problem hiding this comment.
You don't need to check in this file. It is autogenerated.
saadrahim
reviewed
May 2, 2025
| - caption: Tools | ||
| entries: | ||
| - file: container-runtime/index.rst | ||
| title: Container Runtime |
Member
There was a problem hiding this comment.
All the rst files should be in the toc
saadrahim
reviewed
May 2, 2025
| author = "Advanced Micro Devices, Inc." | ||
| copyright = "Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved." | ||
|
|
||
| # Supported linux version numbers |
Member
There was a problem hiding this comment.
I like the automation you've done here.
saadrahim
reviewed
May 2, 2025
saadrahim
requested changes
May 2, 2025
Member
saadrahim
left a comment
saadrahim
left a comment
There was a problem hiding this comment.
You are missing a .readthedocs.yaml file in the project root directory. Please see the template repository. Also, the CI is now running, so you can see the success or failure of the documentation build.
saadrahim
reviewed
May 9, 2025
| "keywords": "AMD, ROCm, Container Runtime, GPU, HPC, Machine Learning" | ||
| --- | ||
|
|
||
| # AMD ROCm Container Runtime Documentation |
Member
There was a problem hiding this comment.
Suggested change
| # AMD ROCm Container Runtime Documentation | |
| # AMD Container Runtime Documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.