Skip to content

Include <iostream> in common_hip.cc for fixing build failure for hip-… #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iotamudelta merged 1 commit into from
Oct 24, 2018
Merged

Include <iostream> in common_hip.cc for fixing build failure for hip-… #289

iotamudelta merged 1 commit into from
Oct 24, 2018

Conversation

@yxsamliu
Copy link

@yxsamliu yxsamliu commented Oct 24, 2018

…clang

@iotamudelta iotamudelta merged commit 676213f into ROCm:master Oct 24, 2018
@iotamudelta iotamudelta added the cherry-picked This pull request has been cherry-picked into pytorch/pytorch upstream. label Jan 14, 2019
akashveramd pushed a commit that referenced this pull request Jun 13, 2025
@gnadathur
Add periodic integration test with signal (#289)
10ef7a6 
Runs the integration test hourly and updates signal badge. Tested on
existing integration test. I will update the badge with periodic test
signal once workflow has landed in this PR.
<img width="516" alt="Screenshot 2024-04-30 at 6 12 00 PM"
src="https://github.com/pytorch/torchtitan/assets/1779702/8adaab3d-df18-483d-a39f-5af316b7edbc">
amd-sriram pushed a commit that referenced this pull request Nov 24, 2025
@sriram-siloai
[rocm7.1_internal_testing] update related_commit
95bee12 
Commit Messages:
- Update README.md (#289)
- Update version to 1.10.0 (#282)
- add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#278)

PRs:
- ROCm/apex#289

Fixes:
- https://example.com/issue-289
- https://example.com/issue-282
- https://example.com/issue-278
@amd-sriram amd-sriram mentioned this pull request Nov 24, 2025
Open
amd-sriram pushed a commit that referenced this pull request Nov 25, 2025
@sriram-siloai
[rocm7.2_internal_testing] update related_commit
0e15815 
Commit Messages:
- Update README.md (#289)
- Update version to 1.10.0 (#282)
- add code to read BUILD_VERSION env variable, so that it is used instead of version.txt when creating a wheel (#278)

PRs:
- ROCm/apex#289

Fixes:
- https://example.com/issue-278
- https://example.com/issue-289
- https://example.com/issue-282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iotamudelta iotamudelta iotamudelta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked This pull request has been cherry-picked into pytorch/pytorch upstream.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yxsamliu @iotamudelta