Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary incompatiblity with JOSM #1

Closed
don-vip opened this issue Jan 7, 2015 · 11 comments

Comments

@don-vip
Copy link
Contributor

@don-vip don-vip commented Jan 7, 2015

Hi,
If you run JOSM check-plugins ant task you will notice it currently fails with this reason:

check-plugins:
[echo] Check of plugins binary compatibility (needs ant 1.8)
[copy] Copying 3 resources to C:\Users\Vincent\JOSM\core\plugin-check
[as:build-signatures] Capturing signatures from C:\Users\Vincent\JOSM\core\dist\josm-custom-optimized.jar
[as:build-signatures] Capturing signatures from C:\Program Files\Java\jdk1.7.0_72\jre\lib\rt.jar
[as:build-signatures] Capturing signatures from C:\Program Files\Java\jdk1.7.0_72\jre\lib\jce.jar
[as:build-signatures] Wrote signatures for 22242 classes.
[as:check-signature] Checking unresolved references to C:\Users\Vincent\JOSM\core\plugin-check\api.sig
[as:check-signature] Ignoring the signatures from file to be checked: C:\Users\Vincent\JOSM\core\plugin-check
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/AdvancedEditorPanel.class:47: Undefined reference: void org.openstreetmap.josm.gui.tagging.TagEditorPanel.(org.openstreetmap.josm.gui.tagging.TagEditorModel, org.openstreetmap.josm.gui.dialogs.properties.PresetListPanel.PresetHandler)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:35: Undefined reference: org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority.IS_IN_STANDARD
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:35: Undefined reference: void org.openstreetmap.josm.gui.tagging.ac.AutoCompletionListItem.(String, org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:36: Undefined reference: org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority.IS_IN_STANDARD
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:36: Undefined reference: void org.openstreetmap.josm.gui.tagging.ac.AutoCompletionListItem.(String, org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:37: Undefined reference: org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority.IS_IN_STANDARD
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:37: Undefined reference: void org.openstreetmap.josm.gui.tagging.ac.AutoCompletionListItem.(String, org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:38: Undefined reference: org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority.IS_IN_STANDARD
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/MemberRoleCellEditor.class:38: Undefined reference: void org.openstreetmap.josm.gui.tagging.ac.AutoCompletionListItem.(String, org.openstreetmap.josm.gui.tagging.ac.AutoCompletionItemPritority)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/list/TurnRestrictionCellRenderer.class:125: Undefined reference: org.openstreetmap.josm.gui.JMultilineLabel
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/list/TurnRestrictionCellRenderer.class:125: Undefined reference: void org.openstreetmap.josm.gui.JMultilineLabel.(String)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/list/TurnRestrictionCellRenderer.class:136: Undefined reference: org.openstreetmap.josm.gui.JMultilineLabel
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/list/TurnRestrictionCellRenderer.class:136: Undefined reference: void org.openstreetmap.josm.gui.JMultilineLabel.(String)
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/TurnRestrictionEditor$SavingAction.class:572: Undefined reference: org.openstreetmap.josm.command.ConflictAddCommand
[as:check-signature] C:\Users\Vincent\JOSM\core\plugin-check\CADTools.jar:org/openstreetmap/josm/plugins/turnrestrictions/editor/TurnRestrictionEditor$SavingAction.class:572: Undefined reference: void org.openstreetmap.josm.command.ConflictAddCommand.(org.openstreetmap.josm.gui.layer.OsmDataLayer, org.openstreetmap.josm.data.conflict.Conflict)

BUILD FAILED
C:\Users\Vincent\JOSM\core\build.xml:519: Signature errors found. Verify them and ignore them with the proper annotation if needed.

I don't know how you build your plugin jar since you don't share the source code (which I find very strange for a Github project by the way) but you must recompile your plugin to latest JOSM if you want to avoid crashes at runtime.

I also don't get it why you include turnrestrictions plugin class files. If you need this plugin at runtime, that's not the way to go. You must use the "Requires" directive in your build.xml.

See https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins#ThemanifestfileforaJOSMplugin for reference.

Cheers,
Vincent

@don-vip

This comment has been minimized.

Copy link
Contributor Author

@don-vip don-vip commented Jan 16, 2016

This plugin has been banned from JOSM.

@don-vip don-vip closed this Jan 16, 2016
@Cetusek

This comment has been minimized.

Copy link
Collaborator

@Cetusek Cetusek commented Mar 10, 2016

Vincent,

I was asked to repair this plugin. I see that all errors are connected with turnrestrictions. I deleted turnrestrictions.jar from lib directory, built CADTools.jar and run check-plugins ant task and there was no error from CADTools.jar. So turnrestrictions.jar is not necessary.

Is it possible to bring this plugin back?

@don-vip

This comment has been minimized.

Copy link
Contributor Author

@don-vip don-vip commented Mar 11, 2016

turnrestrictions.jar is always in source code:
https://github.com/ROTARIUANAMARIA/CADTools/tree/master/lib

@Cetusek

This comment has been minimized.

Copy link
Collaborator

@Cetusek Cetusek commented Mar 11, 2016

I did it locally on my notebook. I cannot push changes because of:

https://github.com/ROTARIUANAMARIA/CADTools: git-receive-pack not permitted

Could you help me?

@don-vip

This comment has been minimized.

Copy link
Contributor Author

@don-vip don-vip commented Mar 11, 2016

did @ROTARIUANAMARIA give you write access to this repository?

@Cetusek

This comment has been minimized.

Copy link
Collaborator

@Cetusek Cetusek commented Mar 14, 2016

Vincent,

The code and CADTools.jar are updated.

@Cetusek Cetusek reopened this Mar 14, 2016
@Cetusek

This comment has been minimized.

Copy link
Collaborator

@Cetusek Cetusek commented Apr 1, 2016

Vincent,

Are you going to include this plugin to JOSM?

@Marekkleciak

This comment has been minimized.

Copy link

@Marekkleciak Marekkleciak commented Apr 13, 2016

Dear Vincent,
please add CADTools to the list.
We are waiting for that, especially because of 3D modeling.
I asked user cetusek for critical review of the bachelor work of my student, Anamaria Rotariu. Cetusek is an deeply involved soft. developer.

With best regards and thanks for your OSM contribution,
Marek

http://wiki.openstreetmap.org/wiki/User:Marek_kleciak

@don-vip

This comment has been minimized.

Copy link
Contributor Author

@don-vip don-vip commented Apr 13, 2016

Sorry for delay. I have removed CADTools from ban list see https://josm.openstreetmap.de/changeset/10143/josm/

Please make sure that someones maintains the plugin now. If I report another blocking issue that causes a lot of trouble for our users, and 18 months pass without any feedback from plugin maintainer, I will ban it again for good. I hope you understand we expect a minimum level of involvement from anyone who makes a JOSM plugin not hosted on OSM SVN repository.

@don-vip don-vip closed this Apr 13, 2016
openstreetmap-mirror pushed a commit to openstreetmap/josm that referenced this issue Apr 13, 2016
@Marekkleciak

This comment has been minimized.

Copy link

@Marekkleciak Marekkleciak commented Apr 13, 2016

Dear Vincent,
thanks a lot! Of course, you´re right!
I have to fix some plug ins more: Enhanced Kendzi3D and dxf import: both made with my support as bachelor projects at the University Brasov. I will find new project owner for the both plugIns-
Recently only CADTools has an new owner: User Cetusek.
Best regards,
Marek

@don-vip

This comment has been minimized.

Copy link
Contributor Author

@don-vip don-vip commented Apr 14, 2016

Great! It's good to see new people taking care of old plugins 👍

floscher pushed a commit to floscher/josm that referenced this issue Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.