Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing GraphQL API for accessing GitHub data #437

Draft
wants to merge 1 commit into
base: master
from

Conversation

@grantwinney
Copy link

grantwinney commented Oct 24, 2019

I wanted to get this "out there" so others could look at it. It's not a complete solution yet, but at least it's a start for addressing #420:

  • I haven't fully refactored GetStatusesAsync in Client.cs or LinkPrBuild in Pr.cs yet. I'm not quite sure where to get the necessary info from or whether there's a official GitHub object to match the StatusInfo class.
  • I think the GraphQL API requires an OAUTH token now, whereas the queries were anonymous before. If that's true, then it'll be possible to make a greater amount of queries, but I'm not sure what the best way is to get an OAUTH token into the program.
  • For now, I've simply commented out the built-in POCOs like PrInfo, IssueInfo, etc.
  • This won't compile as-is, so the build and tests will fail. It's really just to get feedback about what's been done so far.
@grantwinney grantwinney changed the title begin work on using graphql for accessing github Implementing GraphQL API for accessing GitHub data Oct 24, 2019
@13xforever 13xforever self-requested a review Oct 31, 2019
@13xforever 13xforever modified the milestones: v2.14, v2.15 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.