Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: inFAMOUS 2 [BCUS98125] audio broken (#9760) #11553

Closed
Darkhost1999 opened this issue Feb 19, 2022 · 17 comments
Closed

Regression: inFAMOUS 2 [BCUS98125] audio broken (#9760) #11553

Darkhost1999 opened this issue Feb 19, 2022 · 17 comments

Comments

@Darkhost1999
Copy link
Contributor

#9760 Broken audio
RPCS3.log
#11215 Works perfectly
RPCS3.log

@kd-11
Copy link
Contributor

kd-11 commented Feb 19, 2022

Can confirm. Very strange audio pop, seemingly from one ear.

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented Feb 19, 2022

Additional info that might help
I just now tested PPU Interpreter (static) works fine on the modern build.
When using LLVM I turned off my left channel speaker audio in windows settings (no change) turned it back on.
Turn my right channel speaker off in windows settings and the game was completely muted. With the left channel on full volume.
This is using the downmix to stereo audio and no settings were changed from my logs already provided.
If you'd like logs of the PPU Interpreter I can provide those from the modern build as working just fine.

@AniLeo AniLeo changed the title inFAMOUS 2 [BCUS98125] audio broken Regression: inFAMOUS 2 [BCUS98125] audio broken (#9760) Apr 16, 2022
@AniLeo
Copy link
Member

AniLeo commented Apr 16, 2022

Adding @Nekotekina since it broke on #9760

@Xcedf
Copy link

Xcedf commented May 1, 2022

Retested this issue, not 9670 broke this, regression caused by #11379
this exact commit df24cff
reverted it for recent build - audio works

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented May 1, 2022

This is what I hear roaring rapids. The audio is bad I would not wear headphones for the video.
https://youtu.be/V_Iwzc-hNsg
There is no strange audio pop, seemingly from one ear.
I am in progress of cloning the repository in order to test those changes you mention locally and report if the fix also applies to me.

Turn my right channel speaker off in windows settings and the game was completely muted. With the left channel on full volume.

As of my tests today this is outdated. Audio is not isolated to 1 channel anymore.
log

@Darkhost1999
Copy link
Contributor Author

this exact commit df24cff
reverted it for recent build - audio works

Just finished testing reverting it locally on my PC. Still broken.

@Xcedf
Copy link

Xcedf commented May 1, 2022

@Darkhost1999 did you remove PPU cache before testing it?

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented May 1, 2022

@Darkhost1999 did you remove PPU cache before testing it?

No, I did not. The fix does work. 🤦
I really just think PPU verifies itself upon loading and if invalid should/would recompile itself.

@Xcedf
Copy link

Xcedf commented May 1, 2022

@Darkhost1999 It's annoying, but that's how it works, everytime smth changed in PPU LLVM - cache must be recompiled. Thanks for confirming.

@Nekotekina
Copy link
Member

What PPU settings are enabled when the issue is reproducible on master? A bunch of them on Advanced tab.

@Xcedf
Copy link

Xcedf commented May 2, 2022

I tried all that available, no difference

@Darkhost1999
Copy link
Contributor Author

The issue shouldn't require any settings changed for it to immediately have sound issues as soon as you press start a new game

@Nekotekina
Copy link
Member

That's weird that interpreter works since it uses the same logic in master.

@Darkhost1999
Copy link
Contributor Author

Darkhost1999 commented May 2, 2022

Yea, it is weird. Interpreter works fine.
Llvm does not.
All ppu settings in advanced tab appear to have no effect.
Rolling back df24cff
And clearing the ppu cache. Works just fine with LLVM too.

At first I thought because everyone seems to have a different experiences from just a crackle here to roaring rapids constantly that it was just a sign of an underpowered pc. /shrug

@Nekotekina
Copy link
Member

Try #11916 (some wild guess) — don't forget to clear PPU cache.

@Darkhost1999
Copy link
Contributor Author

Yep works just fine. To solve audio issues here

@Darkhost1999
Copy link
Contributor Author

Fix for audio merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants