Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFL Tour - Wrong/Missing Colors #12262

Open
ChwaraeTeg opened this issue Jun 20, 2022 · 10 comments
Open

NFL Tour - Wrong/Missing Colors #12262

ChwaraeTeg opened this issue Jun 20, 2022 · 10 comments
Assignees
Labels
Bug In Progress This issue is actively being investigated at the moment. Regression

Comments

@ChwaraeTeg
Copy link

Please do not ask for help or report compatibility regressions here, use RPCS3 Discord server or forums instead.

Quick summary

NFL Tour has some graphical issues with incorrect colors

Details

NFL Tour has some graphical issues with RPCS3 showing wrong/missing colors on the field as compared to real hardware. The grass appears yellow instead of green; distance line markings, logos etc. appear black instead of the expected colors; end zone is not the right shade of blue.

0. Make sure you're running with settings as close to default as possible

Game requires LLE libvdec to get in-game. Have tried leaving all other settings default, setting Write Color Buffers, setting WCB+RCB+WDB+RDB, and setting all 4 of those + Force CPU Blit - none of these made any difference.

1. Please attach RPCS3's log.

RPCS3.log.gz

2. If you describe graphical issue, please provide an RSX capture and a RenderDoc capture that demonstrate it.

RSX Capture:
https://mega.nz/file/GN0TkJ4b#ka0nXknagLlabrsnDSji27mejCwEnPwrgLFi8qR0BS8

3. Please attach screenshots of your problem.

RPCS3

4. Please provide comparison with real PS3.

NFLTourPS3

5. Please provide your system configuration:

OS - Windows 10 21H2
CPU Intel Xeon E3-1240 v5
GPU NVIDIA GeForce GTX 1060 6GB
Driver version 512.95.0.0

Please include.

  • Anything else you deem to be important
@kd-11 kd-11 self-assigned this May 2, 2023
@kd-11 kd-11 added the Bug label May 2, 2023
@kd-11
Copy link
Contributor

kd-11 commented May 2, 2023

Still an issue?

@Triticum0
Copy link

Triticum0 commented May 2, 2023

Yes
RPCS3.log.gz
NPUB90072_screenshot_2023_05_02_19_23_39

@ChwaraeTeg
Copy link
Author

RenderDoc capture if it helps:
https://mega.nz/file/7AkXXZxS#k6T-LAQTS8noXTY4Ux9Wfi_YKpcR-lO4DzsXAaotm5M

Corresponding log:
nfltour.log.gz

@Triticum0
Copy link

Retested with v0.0.30-15916-80b7fd5f. No changes

@kd-11 kd-11 added the In Progress This issue is actively being investigated at the moment. label Oct 3, 2024
@kd-11
Copy link
Contributor

kd-11 commented Oct 3, 2024

This one looks interesting.

@kd-11
Copy link
Contributor

kd-11 commented Oct 7, 2024

This one is insanity.
The game basically disables an attribute channel then proceeds to read from it in shaders.

enable_attr(0, ...);
disable_attr(3, ...);
disable_attr(8, ...);

// Some other setup

enable_attr(0, ...);
enable_attr(8, ...);

draw();

The shader expects attr 3 to be present (diffuse color intensity). Without being set we fall back to default (verified with hardware tests years ago) which is alpha value only of 1.
There may be a method to this madness however, if they actually just want to pick the alpha channel. But why not shuffle it to "on" state in the shader by just picking .a instead?
The color target is of type "B8" - I wonder if the rendering is configured to pick from "A"?

@kd-11
Copy link
Contributor

kd-11 commented Oct 7, 2024

Truncating the word so that A is mapped to B gives a completely overblown image, the pitch colors are correct but way too bright. I feel we're missing something else, this one needs some hardware tests.

@mysteria25
Copy link

mysteria25 commented Oct 9, 2024

@kd-11 This game used to show proper colors but regressed it seems.

Build 0.0.6-8647- Field colors / lighting work "correctly" except the field is very grainy no matter what resolution or AF you use. https://github.com/RPCS3/rpcs3-binaries-win/releases/download/build-14aa3b3360e22ec78427202aaf37ff1e17d53999/rpcs3-v0.0.7-8647-14aa3b33_win64.7z

nfl.mp4

Build 0.0.7-8650 - Field Colors / lighting regresses and has been that way ever since afaik.
https://github.com/RPCS3/rpcs3-binaries-win/releases/download/build-efa501dac67bc8980f9c85036dca5d417a90ad9c/rpcs3-v0.0.7-8650-efa501da_win64.7z

nfl2.mp4

Regression? PR = #6485

Settings: Vulkan, WCB + Force CPU Blit. Firmware: Automatic + libvdec enabled. ASMJIT SPU Recompiler
Windows 10

@kd-11
Copy link
Contributor

kd-11 commented Oct 9, 2024

Thanks. This narrows things down a bit.

@kd-11
Copy link
Contributor

kd-11 commented Oct 9, 2024

As discovered earlier it has to do with the disabled input attribute.
I need to do extensive testing on that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug In Progress This issue is actively being investigated at the moment. Regression
Projects
None yet
Development

No branches or pull requests

4 participants