Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] All Pro Football 2k8 - flimmering on helmets + pixelated banners (#13236) #13253

Closed
Dude85 opened this issue Jan 18, 2023 · 15 comments · Fixed by #15931
Closed

[Regression] All Pro Football 2k8 - flimmering on helmets + pixelated banners (#13236) #13253

Dude85 opened this issue Jan 18, 2023 · 15 comments · Fixed by #15931
Assignees

Comments

@Dude85
Copy link

Dude85 commented Jan 18, 2023

Quick summary

Game worked fine with build rpcs3-v0.0.26-14568-1852b370. Latest updates show graphical glitches (flimmering on helmets + pixelated banners)

Details

No response

Build with regression

v0.0.26-14570

Attach two log files

RPCS3.log.gz
RPCS3.log.gz

Attach capture files for visual issues

Screenshot 2023-01-18 120642

System configuration

No response

Other details

No response

@mysteria25
Copy link

mysteria25 commented Jan 19, 2023

Your log says you have WCB and CPU blit enabled. Why have them enabled? afaik, this game doesnt need those On anymore. does it fix it if you disable those options?

@Dude85
Copy link
Author

Dude85 commented Jan 19, 2023

You need both. Either if one is turned off or both, 3D animations in the menus are gone. It`s a common behavior which is well described in several forums or on Reddit.

@Dude85
Copy link
Author

Dude85 commented Jan 19, 2023

Did some more testing. Without both options, the graphical glitches described are gone, but as mentioned the 3D animations are missing and ther're glitches in the menu.

WCB and CPU blit activated latest build:

WCB and CPU blit activated latest build 1
WCB and CPU blit activated latest build 2

WCB and CPU blit deactivated latest build:

WCB and CPU blit deactivated

@kd-11
Copy link
Contributor

kd-11 commented Jan 19, 2023

You need to narrow down when the problem started to get any traction.

@Dude85
Copy link
Author

Dude85 commented Jan 19, 2023

All versions tested with same custom config (CPU blit ON & WBC ON):

0.0.26-14542: OK
0.0.26-14564: OK
0.0.26-14568: OK
0.0.26-14573: NOK
0.0.26-14577: NOK
0.0.26-14580: NOK
0.0.26-14584: NOK

@YuriNator557
Copy link

14573 is PR #13232 , not sure how that could break it

@Darkhost1999
Copy link
Contributor

There is still a range greater than 1 PR of builds that could be causing the issue. They just need to bisect a little more

@Dude85
Copy link
Author

Dude85 commented Jan 19, 2023

Results after further testing:

0.0.26-14569: OK
0.0.26-14570: NOK

@Asinin3
Copy link
Contributor

Asinin3 commented Jan 20, 2023

If that's the case then it was broken by #13236

@kd-11 kd-11 self-assigned this Jan 20, 2023
@kd-11
Copy link
Contributor

kd-11 commented Jan 23, 2023

The regression is simply an unhidden bug. We're missing a signal elsewhere and letting through some updates incorrectly triggers the right behavior. I'm still investigating.

@Dude85
Copy link
Author

Dude85 commented Jan 23, 2023

Thanks for your feedback and checking this issue. Fingers crossed that you find a solution quickly.

@kd-11
Copy link
Contributor

kd-11 commented Jan 25, 2023

No luck so far. The problem is caused by the interaction between CPU blit and write color buffers, but it seems to be timing dependent and not consistent. Injecting random calls to memory protection hides the bug, which is why the old code that spammed surface dirty was working, but it was completely wrong to do that. The biggest issue here is that the affected resources are only created once during loading and then remain so you cannot debug traditionally.
I'll have to circle back to this one at a later time.

@Dude85
Copy link
Author

Dude85 commented Jan 26, 2023

Damn, that doesn't sound so easy. Thanks for the feedback and good luck finding this bug, even if it needs some more time to be spend on!

@Imdakine1
Copy link

Ongoing inconsistent graphical glitch. image

@AniLeo AniLeo changed the title [Regression] All Pro Football 2k8 [Regression] All Pro Football 2k8 (#13236) Jun 24, 2023
@AniLeo AniLeo added the RSX label Jun 24, 2023
@AniLeo AniLeo changed the title [Regression] All Pro Football 2k8 (#13236) [Regression] All Pro Football 2k8 - flimmering on helmets + pixelated banners (#13236) Jan 1, 2024
@kd-11
Copy link
Contributor

kd-11 commented Aug 12, 2024

I checked this one earlier today. The glitches are gone, but it was crashing when CPU blit is enabled. That crash is fixed by #15931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants