Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL/Vulkan: One Piece: Pirate Warriors graphical issues #2262

Open
1 of 2 tasks
MarioSonic2987 opened this issue Jan 13, 2017 · 36 comments · Fixed by #8243 or #10733
Open
1 of 2 tasks

GL/Vulkan: One Piece: Pirate Warriors graphical issues #2262

MarioSonic2987 opened this issue Jan 13, 2017 · 36 comments · Fixed by #8243 or #10733
Assignees

Comments

@MarioSonic2987
Copy link
Contributor

MarioSonic2987 commented Jan 13, 2017

As of 0.0.25-14507:

Old comment

DX12 - Freezes in title screen with:

·F {rsx::thread} class std::runtime_error thrown: HRESULT = La instancia de dispositivo de GPU se ha suspendido. Use GetDeviceRemovedReason para averiguar cuál es la acción adecuada.
(in file C:\rpcs3\rpcs3\Emu\RSX\D3D12\D3D12RenderTargetSets.cpp:279)

OGL:

Vulkan:

Crashes in same moment as in these pictures.

Outputs in all backends:

·E {rsx::thread} RSX: Unimplemented sca_opcode BRB
·E {rsx::thread} RSX: Unimplemented sca_opcode BRB

Shaderlog DX12
Shaderlog OpenGL
Shaderlog Vulkan
RenderDoc Vulkan (Title screen & Main menu)

@SakataGintokiYT
Copy link
Contributor

@AniLeo

Crash by sysnet issue on the line 425 'recvfrom'
After disabling this feature, the game starts normally without crash.

W {PPU[0x1000000] Thread (main_thread) [0x00812824]} libnet: recvfrom(s=0, buf=*0x0, len=0, flags=0x80, addr=*0xd001f684, paddrlen=*0xd001f670)

Fatal error
Unhandled Win32 exception 0xC0000005.
Segfault reading location 0000000000000000 at 000000000021ef9f.
Instruction address: 000000000021ef9f.
Function address: 000000000021eec0 (base+0x20eec0).
Module name: 'rpcs3.exe'.
Module base: 0000000000010000.
RPCS3 image base: 0000000000010000.

@kd-11
Copy link
Contributor

kd-11 commented Feb 25, 2017

Please retest with #2426

@MarioSonic2987
Copy link
Contributor Author

MarioSonic2987 commented Feb 25, 2017

@kd-11

With #2426, Luffy's trousers are rendered properly. Remains the other glitches (no lighting, no water).

Shaderlog Vulkan
RenderDoc Vulkan

@SakataGintokiYT
Copy link
Contributor

SakataGintokiYT commented Feb 25, 2017

@kd-11
OpenGL-RenderDoc
Shaderlog:


**DX12**
Unhandled Win32 exception 0xC0000005.
Segfault reading location ffffffffffffffff at 00000000003bd400.
Instruction address: 00000000003bd400.
Module name: 'rpcs3.exe'.
Module base: 0000000000010000.
RPCS3 image base: 0000000000010000.

Shaderlog:
Log:

@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Feb 26, 2017

menu bugger and ingame strange blur
capture d ecran 2017-02-26 01 18 08

capture d ecran 2017-02-26 01 18 27
capture d ecran 2017-02-26 01 20 57

@MarioSonic2987
Copy link
Contributor Author

Hits this (same as Skate 2):
E {rsx::thread} RSX: Surface color buffer: Unsupported surface color format (0xd)

On BRB side, it's the same in VK and GL.

In DX12, outputs:

·F 0:03:07.672151 {rsx::thread} class std::runtime_error thrown: HRESULT = La instancia de dispositivo de GPU se ha suspendido. Use GetDeviceRemovedReason para averiguar cu⬠es la acci󮠡decuada.
(in file C:\rpcs3\rpcs3\Emu\RSX\D3D12\D3D12RenderTargetSets.cpp:279)

Shaderlog DX12

@MarioSonic2987
Copy link
Contributor Author

With #2482, lighting effects are improved.

@SakataGintokiYT
Copy link
Contributor

OpenGL
Fotoszok.pl
#2962

@MarioSonic2987
Copy link
Contributor Author

MarioSonic2987 commented Aug 18, 2017

With jarves' build (https://ci.appveyor.com/project/jarveson/rpcs3/build/0.0.3-154), fixes water in title screen.
image
@Zangetsu38

@MarioSonic2987
Copy link
Contributor Author

Tested with cde29ab:
image

@Asinin3
Copy link
Contributor

Asinin3 commented Sep 4, 2017

@MarioSonic2987 I think this was fixed with: 9c70d2a

@MarioSonic2987
Copy link
Contributor Author

@Asinin3 Only fixed a portion of broken geometry.

@AniLeo
Copy link
Member

AniLeo commented Sep 21, 2017

Retested but latest build driver crashes Vulkan on AMD, reported to kd-11.

OpenGL Exploding Vertices
image

@MarioSonic2987
Copy link
Contributor Author

With PR #3488, has water effects, but with a white texture:

image

@MarioSonic2987
Copy link
Contributor Author

With #3744, lighting effects are improved (look at Luffy).
image
image

@AniLeo AniLeo changed the title DX12/GL/Vulkan: One Piece: Pirate Warriors RSX: One Piece: Pirate Warriors (Exploding vertices) Nov 28, 2017
@kd-11 kd-11 changed the title RSX: One Piece: Pirate Warriors (Exploding vertices) One Piece: Pirate Warriors - Exploding vertices Dec 5, 2017
@MarioSonic2987
Copy link
Contributor Author

@MarioSonic2987
Copy link
Contributor Author

With #4312, gamma is fixed.
image

@hcorion
Copy link
Member

hcorion commented Mar 29, 2018

Was this fixed in #4356

@AniLeo
Copy link
Member

AniLeo commented Mar 29, 2018

No

image

@MarioSonic2987
Copy link
Contributor Author

With #4902, fixes black and misplaced textures in levels.
image

@reaper185
Copy link

exploding vertices also happens in Dynasty Warriors Gundam Reborn #4632

@MarioSonic2987
Copy link
Contributor Author

MarioSonic2987 commented Aug 28, 2018

This screenshot catches more graphical issues:

image
RenderDoc (OpenGL)

@Zangetsu38
Copy link
Contributor

maybe need change issue name now ? with "One piece rendering Issue" ?

@MarioSonic2987 MarioSonic2987 changed the title One Piece: Pirate Warriors - Exploding vertices GL/Vulkan: One Piece: Pirate Warriors graphical issues Sep 15, 2018
@MarioSonic2987
Copy link
Contributor Author

With #5436, fixes broken and missing effects, although the water effects are still not perfect.
image

@kd-11
Copy link
Contributor

kd-11 commented Aug 19, 2019

Needs an update.

@MarioSonic2987
Copy link
Contributor Author

There's still broken effects in water and flickering colors during cutscenes.

Images

image
image

RenderDoc VK
RSX Captures

@elad335
Copy link
Contributor

elad335 commented Mar 25, 2020

Retest with #7846

@MarioSonic2987
Copy link
Contributor Author

Nothing changed with PR #7846. Same glitches as before.
image

@kd-11 kd-11 self-assigned this May 8, 2020
@kd-11
Copy link
Contributor

kd-11 commented May 8, 2020

Attach recent RSX capture of broken water effects. The format has changed recently.

@Kyon-irk
Copy link

Kyon-irk commented May 9, 2020

Nothing changed
1

@Emulator-Team-2
Copy link

Emulator-Team-2 commented May 10, 2020

Edit: Fixed by #8243.


RSX Capture:
-(Broken water effects).

Link: RSX-Capture-(Build-0.0.10-10346 - Deleted.)

@Emulator-Team-2
Copy link

Emulator-Team-2 commented May 17, 2020

Remaining glitches:
-(The background remains black in the initial cutscene instead of blue.)


Edit:
-(Flickering colors and missing blur in cutscenes.)


Update:

RDC Capture and screenshot for remaining glitches.

(Flickering colors and missing blur in cutscenes.)

RPCS3: 1
PS3: 2


RPCS3: 3
PS3: 4

  • (RenderDoc):
    Link:
    [rdc capture-1 - Deleted.]
    [rdc capture-2 - Deleted.]

Details:
-rpcs3-v0.0.17-12621
-Issue: Flickering colors and missing blur in cutscenes.

OS: Windows 10 64-bit
CPU: Intel i7-10700
GPU: GTX 1660 - ( Driver version: 471.41.0.0 )

@kd-11 kd-11 reopened this May 17, 2020
@kd-11 kd-11 added the In Progress This issue is actively being investigated at the moment. label Aug 18, 2021
@kd-11
Copy link
Contributor

kd-11 commented Aug 19, 2021

Flickering and other glitches are solved by #10733
However, the background remains black during the intro sequence instead of blue. I can fix this in a one-line fix but hardware tests have refuted my hypothesis so I will not commit the hack.

@kd-11 kd-11 removed the In Progress This issue is actively being investigated at the moment. label Aug 19, 2021
@MarioSonic2987
Copy link
Contributor Author

MarioSonic2987 commented Aug 20, 2021

It remains black textures in most cutscenes, like this background in Episode 0.
image

@MSuih MSuih reopened this Aug 20, 2021
@Emulator-Team-2
Copy link

Update:

-Still an issue, tested with the latest master build: (0.0.23-14031).

Screenshots:

(PS3/RPCS3 Comparisons)

PS3:
1
RPCS3:
2

(RenderDoc/RSX Capture)
Link:
rdc capture-vk
rsx capture

System configuration:

  • OS: Windows 10 64-bit
  • CPU: Intel i7-10700
  • Memory: 16GB RAM
  • GPU: GTX 1660
  • Driver version: 512.95.0.0

@Emulator-Team-2
Copy link

Still an issue, tested with the latest master build: (rpcs3-v0.0.30-15912).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet