Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLJS10053] Tales of Vesperia - Remaining rendering issues #4357

Open
9 of 11 tasks
GeniusMage opened this issue Mar 29, 2018 · 45 comments
Open
9 of 11 tasks

[BLJS10053] Tales of Vesperia - Remaining rendering issues #4357

GeniusMage opened this issue Mar 29, 2018 · 45 comments

Comments

@GeniusMage
Copy link
Contributor

GeniusMage commented Mar 29, 2018

Continuation of #2707.

Issues to fix:

  • Black characters
  • Blue veil
  • Shadows: Not every character gets their shadow, but it's no longer a square.
  • Scrambled text
  • Lighting issue
  • Frame persistence issue
  • Half-screen issue
  • Possible Alpha glitch (?) on the fountain in Zaphias' lower quarter
  • Wrong colors on characters textures (unrelated to SRM, the issue appears even without it)
  • Lack of bloom in certain cutscenes
  • Requires Strict Rendering Mode
Screenshots

bandicam 2018-03-29 10-19-59-500
bandicam 2018-03-29 10-21-49-058

Log

@kd-11
Copy link
Contributor

kd-11 commented Mar 29, 2018

Requires strict mode is not a bug. The solution would be to make strict mode permanent then everyone is forced to use it all the time.

@kd-11
Copy link
Contributor

kd-11 commented Mar 29, 2018

A patch.yml entry could force the game to not do the risky stuff (really only one thing) but thats for interested community members to do. Requires a hex editor and replacing 2560 with 1280 where it creates that bugged double-width surface declaration.

@Illynir
Copy link

Illynir commented Apr 1, 2018

I tested a little, the shadows work randomly, sometimes some characters have, sometimes not. The portrait during the fights is green, there is a problem with the alpha, we see a rectangle around the portrait and the fountain at the beginning. The chain on the dog at the beginning also makes a strange movement

unknown
unknown2

@GeniusMage
Copy link
Contributor Author

GeniusMage commented Apr 1, 2018

The chain of the dog moving is not a bug, it happens on real hardware too.
You're using kd's master, something in his build causes the green portrait (EDIT: now on PR 4382 fixed)

@Illynir
Copy link

Illynir commented Apr 1, 2018

Ok for the green portrait, however just checked on a real PS3 and the dog chain on the intro is quite normal unlike RPCS3...

There also remains the alpha problem of the fountain and the portrait.

@wakka1
Copy link

wakka1 commented May 27, 2018

Tested after the latest animation speedup PR #4661
Current issues i noticed :

1- fountain glitch
untitled4

2- half-screen issue during menus and some cut-scenes
half-width

3- Character outline are jagged (aliasing?)
4- wrong colors. Noticeable on pink hair and the guard on the left
5- i may be wrong on this one, but i think a faint bloom is missing on the emulator (faces + clouds)
rpcs3
real ps3

edit : forgot to mention the chain on the dog glitch in the beginning is also still there.

windows 10
i7 7700
16gb ram
gtx 1060

@GeniusMage
Copy link
Contributor Author

Those are all listed (except the bloom, I'll check and add it if necessary)
Character edges are obviously jagged, since it's 720p and FXAA is not applied by the emulator.
The dog chain glitch is not a bug, it happens on real hardware (and yes, I have retested, it does happen, though not consistently).

@pauls-gh
Copy link
Contributor

I debugged the half-screen issue. It appears to be an rpcs3 issue with surface width/height changes.

I should have a fix soon (1-2 days).

@Illynir
Copy link

Illynir commented May 29, 2018

Debuggued this should result in fixing a lot of other games with a similar problem in addition.

@GeniusMage
Copy link
Contributor Author

Alright, I added the fountain glitch and the bloom issue to the first post.
I think the bloom issue is actually there because light isn't being quite properly applied to characters.
I also believe the fountain glitch could be related to the characters texture bug.

@wakka1
Copy link

wakka1 commented May 30, 2018

Shadows bug.
https://imgur.com/OAXzgAs

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 1, 2018

Quick update on half screen issue. Initial idea for a fix didn't pan out, but I haven't given up yet.

@Zangetsu38
Copy link
Contributor

for shadow bug, i have already report this to kd, i have see very lot game with same bug

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 1, 2018

I think I've figured out the half-screen issue. PR coming soon.

half_screen_fix

@asbel123
Copy link

asbel123 commented Jun 2, 2018

Best worst glitch before U go to ride dragon to top of Tower of gears U get 1fps Cutscene worst bloom I am rember real PS3 has that slow down too.

Don't let people on YouTube this game playable.

https://youtu.be/9gThDuVT0os go to 22.26 on that YouTube video on the link this the Cutscene U get 1 fps

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 2, 2018

#4692

This PR looks like it fixes both

  • half screen
  • fountain alpha issue (nice side effect of the half screen fix).

@fifazalata
Copy link

@pauls-gh is it a hacky fix that will need more work or a proper fix?
& btw thanks for ur dedicated work towards a smooth ToV experience ;)

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 2, 2018

It's hacky and it will need more work and a proper fix. kd-11 is taking a look a it.

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 2, 2018

kd-11 has a proper fix for the half-screen issue. #4698

It fixes

  • half-screen issue in Vesperia/Graces
  • fountain issue in Vesperia
  • non-aligned cell-shading in Graces

Known issues with kd-11's change.

  • cell-shading is very pronounced in Vesperia.
  • blue filtering (of distance objects) in town is missing.

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 6, 2018

I spent some time looking at the character texture color issue. This is easily seen in the first cut-scene. The characters faces look darker (more orange) than the PS3 version.

I used renderdoc to capture the scene on RPC3. I then captured the same scene with Xenia (xbox360 emulator). Xenia displays the correct skin color in the scene.

I found the same face texture on both rpcs3 and Xenia. It appears that the skin color is simply darker in RPC3 than Xenia. The red/yellow components looks exactly the same as Xenia, but the blue component is darker for some reason.

The face texture is BC3 (compressed, 5:6:5 alpha 8 bit). Interestingly, the ear texture (a separate texture) is the correct color, but it is BC1 (compressed, 5:6:5 alpha 1 bit). I'm not sure if this matters as I assume both textures are read directly from the TOV ISO files. I don't think there is any conversion done by rpcs3.

Xenia (xbox 360 emulator) - correct face color

renderdoc_facecolor_xenia

rpcs3 - incorrect face color

renderdoc_facecolor_rpcs3

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 7, 2018

If you zoom in around the eye lid, you can see there are splotches of the correct color. It's almost like the artist gave up, or a failed flood fill. Strange.

@asbel123
Copy link

asbel123 commented Jun 7, 2018

Can do higher deatil like texture mod like final fantasy X hd PC version or use Photoshop that's what Xenoblade Wii used to fix character eyes.

@Ristellise
Copy link

Ristellise commented Jun 7, 2018

@pauls-gh If you look REALLY closely at the Xenia one, there is a slight color difference in xenia's. the eyelids and the rest of the face. I guess its once of those RPCS3 color issues.

@pauls-gh
Copy link
Contributor

pauls-gh commented Jun 7, 2018

@Ristelle - you're right. The "Night Light" on Win10 was masking the difference for me.

@Ristellise
Copy link

On entering Capua Nor for the first time, Game Freezes with Trap Exception:
RPCS3.log.gz

@asbel123
Copy link

asbel123 commented Jun 9, 2018

U get it in before U go to Tower of gears U framerate will drop to 1where lots of solder there is a lots a trap error until they fix it or wait E3 tales of vesperia remastered version come out

@GeniusMage
Copy link
Contributor Author

Trap errors happen in specific areas when compiling some shaders.
Usually, you can reload the game after a crash and go past a spot.
Knowing where those spots are can help, as you'd know where to absolutely save, though I recommend always saving before leaving or entering any new area (town or dungeon), if possible.

@elad335
Copy link
Contributor

elad335 commented Oct 15, 2018

Still an issue?

@GeniusMage
Copy link
Contributor Author

Just tested on one of the latest builds, the texture bug is still there, and the bloom is apparently also lacking (looks like wakka1's screenshot from May 27th, point 5).
Though to be fair, the same texture bug appeared on official WIP screenshots from the remaster (textures that weren't revamped yet), it could be an issue with the textures themselves or how a PC driver treats them.

@Ristellise
Copy link

Well I really shouldn't be bumping a dead post but as of Build 52ac0a9, the Game has a constant spam of RSX TODO: Resource used before memory initialization

@GeniusMage
Copy link
Contributor Author

It's not closed, so feel free to post.
I've found this too:
Deidon
The blue effect is out of place.
No SRM
There's also been some changes without SRM, though I'm not sure how new this is.

@Parthorisian
Copy link

Not problem anymore, Sega just ported this game to Windows yet :)

@AniLeo
Copy link
Member

AniLeo commented Jan 15, 2019

doesn't matter, the game port doesn't magically make it fixed on the emulator

@Ristellise
Copy link

Also, it aint Sega but Bandai Namco.

@kd-11
Copy link
Contributor

kd-11 commented Aug 19, 2019

Needs an update or close.

@Illynir
Copy link

Illynir commented Aug 19, 2019

The last two problems are always relevant today

@GeniusMage
Copy link
Contributor Author

Couldn't do extensive testing since my PC seems to hate the emulator currently (Vulkan doesn't work on my end, and OGL is pretty slow, I blame my iGPU).
SRM is no longer needed, and from what I've seen the last two issues are still there.
I'll try to test more once I've changed my CPU sometime next month.

@GeniusMage
Copy link
Contributor Author

Re-tested on latest download version, and managed to get it to work on Vulkan (turns out it was Turing's fault).
The last two issues are still there. I'm still unsure if that texture issue can be fixed.

@digitaldude555
Copy link

It is time for update @GeniusMage

@GeniusMage
Copy link
Contributor Author

There doesn't appear to be any changes.
Face

@Realmantik
Copy link

@GeniusMage, time to retest. Kd-11 added updates to texture rendering, that have solved problems in visuals in many games.

@digitaldude555
Copy link

@GeniusMage retest.

@Illynir
Copy link

Illynir commented Jun 12, 2021

Sans titre

Not fixed, alas.

@Mrlinkwii
Copy link
Contributor

how is this on the latest release

@Illynir
Copy link

Illynir commented Feb 23, 2024

Nothing has changed. Alas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests