Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken colors with AA Enabled on NVIDIA Kepler #6103

Closed
AniLeo opened this issue Jun 17, 2019 · 28 comments
Closed

Broken colors with AA Enabled on NVIDIA Kepler #6103

AniLeo opened this issue Jun 17, 2019 · 28 comments
Assignees
Labels
Driver: NVIDIA Proprietary NVIDIA OpenGL or Vulkan driver Render: Vulkan

Comments

@AniLeo
Copy link
Member

AniLeo commented Jun 17, 2019

Some users reported broken colors with AA Enabled on Skate 3, and that disabling AA fixes the issue

  • GTX 760
  • GTX 670
  • GT 640

RSX Capture: https://drive.google.com/file/d/1umE-qLgY3RJ8t056fPejGmbsoV30eQQY/view (GT 640)

RSX Capture renders with correct colors for me on R9 280X

@ghost
Copy link

ghost commented Jun 17, 2019

This also affects my GTX 760.

@AniLeo AniLeo changed the title Broken colors with AA Enabled on GeForce 600 series Broken colors with AA Enabled on old GeForce cards Jun 17, 2019
@kd-11
Copy link
Contributor

kd-11 commented Jul 3, 2019

I have a theory as to why this is happening, I'll push some commits for it soon.

@kd-11 kd-11 self-assigned this Jul 12, 2019
@Cereal-Killa
Copy link
Contributor

Same here, GTX 770.

Thanks!

@NovaPrima
Copy link

This happens with Tomb Raider Trilogy [BLES01195] too, but only with Vulkan.

tomb2
tomb

v0.0.6-8416 Alpha [2019-07-25]
RPCS3.log.gz

@Leopard20
Copy link

Leopard20 commented Aug 19, 2019

Same issue with Catherine:
Screenshot (22)

GTX 760m

@PaulBGD
Copy link

PaulBGD commented Sep 7, 2019

Happens with The Sly Collection (BCUS98246): https://www.youtube.com/watch?v=UPF7JkgBix0

Disabling anti-aliasing does fix it, or switching to OpenGL. There's more info in my previous issue linked above.

@AniLeo
Copy link
Member Author

AniLeo commented Oct 15, 2019

Still reported to be happening

@Cereal-Killa
Copy link
Contributor

@PaulBGD @Leopard20 @NovaPrima @Cereal-Killa test with
https://ci.appveyor.com/api/buildjobs/lko1t51vi2rmibel/artifacts/rpcs3-v0.0.7-8894-89f582dd_win64.7z

This build seems to freeze on my PC:

E {RSX [0x000bcb0]} RSX: F {RSX [0x000bcb0]} RSX: class std::runtime_error thrown: Failed to compile compute shader (in file C:\projects\rpcs3\rpcs3\Emu\RSX\VK\VKHelpers.h:3210)

I cleared all caches and retried, same exception gets thrown.

gnqEGbcc5t

wuFq9j1LN7

@13xforever
Copy link
Contributor

please always provide full log instead of a screenshot

@Cereal-Killa
Copy link
Contributor

please always provide full log instead of a screenshot

Absolutely.
RPCS3.log.gz

@kd-11
Copy link
Contributor

kd-11 commented Oct 15, 2019

New build compiling here https://ci.appveyor.com/project/kd-11/rpcs3/builds/28132087

@Cereal-Killa
Copy link
Contributor

New build compiling here https://ci.appveyor.com/project/kd-11/rpcs3/builds/28132087

Thank you.

First time I ran it the emulator terminated by itself, then I ran it again and this is how it rendered:

1eWVYwRwiI

The "stable" branch renders like this for comparison:

kjIunBQGta

@Cereal-Killa
Copy link
Contributor

Log: RPCS3.zip

@kd-11
Copy link
Contributor

kd-11 commented Oct 15, 2019

It appears format conversion on these old cards is taken literally (which is completely wrong) and means a workaround is required in the shader.

@kd-11
Copy link
Contributor

kd-11 commented Oct 15, 2019

This build works around this problem. Unfortunately, this also means I will need to gather chip IDs for maxwell and kepler cards since right now it is applied to all unknown nvidia cards and I have only registered pascal and up. I'll try and gather the required device IDs in the next day or two, since that will have to be merged before the workaround to avoid breaking things for everyone else.

@kd-11 kd-11 changed the title Broken colors with AA Enabled on old GeForce cards Broken colors with AA Enabled on NVIDIA Kepler Oct 15, 2019
@kd-11 kd-11 added Driver: NVIDIA Proprietary NVIDIA OpenGL or Vulkan driver Render: Vulkan and removed Bug RSX labels Oct 15, 2019
@Cereal-Killa
Copy link
Contributor

This build works around this problem. Unfortunately, this also means I will need to gather chip IDs for maxwell and kepler cards since right now it is applied to all unknown nvidia cards and I have only registered pascal and up. I'll try and gather the required device IDs in the next day or two, since that will have to be merged before the workaround to avoid breaking things for everyone else.

I appreciate your hard work.

10DE 1184 - 196E 1033

LaLNKZMvH3

@kd-11
Copy link
Contributor

kd-11 commented Oct 16, 2019

Check if it is fixed by #6780

@Cereal-Killa
Copy link
Contributor

Check if it is fixed by #6780

worked like a charm 😍
thank you!!

rpcs3_vYU4oXBkMC

@Cereal-Killa
Copy link
Contributor

FYI, I get twice the FPS without AA.

rpcs3_mBkroVwOom

@kd-11
Copy link
Contributor

kd-11 commented Oct 16, 2019

Thats a bit of an unfair comparison since MSAA is technically smart upscaling. Makes more sense to compare MSAA vs something like 200% scaling. Even then, due to some features missing from NVIDIA cards, they can perform very poorly at times.

@kd-11
Copy link
Contributor

kd-11 commented Oct 16, 2019

Closing as fixed.

@kd-11 kd-11 closed this as completed Oct 16, 2019
@Cereal-Killa
Copy link
Contributor

Thats a bit of an unfair comparison since MSAA is technically smart upscaling. Makes more sense to compare MSAA vs something like 200% scaling. Even then, due to some features missing from NVIDIA cards, they can perform very poorly at times.

No problem man, just wanted to point that out in case it was something not expected, graphics look more or less the same even without AA considering the resolution.
Thank you

@kd-11
Copy link
Contributor

kd-11 commented Nov 1, 2019

There have been a few developments over the past 24h that tangentially relate to this ticket. Please check if MSAA still works ok on rpcs3's latest master (wait about an hour for it to build). Alternatively, just test with the build from #6930

@Cereal-Killa
Copy link
Contributor

Cereal-Killa commented Nov 1, 2019

There have been a few developments over the past 24h that tangentially relate to this ticket. Please check if MSAA still works ok on rpcs3's latest master (wait about an hour for it to build). Alternatively, just test with the build from #6930

The game ran incredibly well with AA set to Auto on this build, it's butter smooth really, only thing I noticed is that after reaching the game main menu the console will start throwing an endless exception, but the game is still playable, it didn't seem to affect anything:

SPU[0x2000003] Thread (job Manager - Job Thread) Please report to the devloper (0x059e8).

rpcs3_dgPkpNKnhp

RPCS3.log.gz

@Drayano
Copy link

Drayano commented Dec 28, 2019

Sorry for posting on this old issue but that's the first one that came up when doing a search on github issues, I know intel isn't technically supported but the same problem happens with my igpu (intel uhd 630), disabling aliasing fix it.

@levonnn
Copy link

levonnn commented Jan 2, 2022

Mortal Kombat II [NPUB30004] has the same issue.

@kd-11
Copy link
Contributor

kd-11 commented Jan 2, 2022

Please open new tickets with full details regarding your setup, this ticket is marked as closed.

@RPCS3 RPCS3 locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Driver: NVIDIA Proprietary NVIDIA OpenGL or Vulkan driver Render: Vulkan
Projects
None yet
Development

No branches or pull requests

9 participants