Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Retro/Grade messed up graphics on Vulkan and OpenGL (#6357) #6688

Closed
benderscruffy opened this issue Oct 1, 2019 · 10 comments · Fixed by #14934
Closed

Regression: Retro/Grade messed up graphics on Vulkan and OpenGL (#6357) #6688

benderscruffy opened this issue Oct 1, 2019 · 10 comments · Fixed by #14934
Assignees

Comments

@benderscruffy
Copy link

benderscruffy commented Oct 1, 2019

have tried differant settings and still the graphics are messed up
most of the time it is a black screen with the music and sound fx
retro
RPCS3.log.gz

@benderscruffy benderscruffy changed the title Retro/Grade - [NPUB30280] messed up graphics Retro/Grade - [NPUB30280] messed up graphics on opengl Oct 4, 2019
@AniLeo
Copy link
Member

AniLeo commented Jan 9, 2020

Needs an RSX capture

@benderscruffy benderscruffy changed the title Retro/Grade - [NPUB30280] messed up graphics on opengl Retro/Grade - [NPUB30280] messed up graphics on Vulkan and Opengl Jan 28, 2020
@AniLeo
Copy link
Member

AniLeo commented Apr 12, 2020

@kd-11 for triaging what kind of graphic issue is this

@Asinin3
Copy link
Contributor

Asinin3 commented Sep 15, 2021

Still an issue, graphics just output garbage on VK and OGL. tried multiple settings and nothing helped. Relaunching game can output different graphics so don't mislead yourself into thinking one setting helped.
image
No RSX capture because it kept crashing e.g with:

(in file D:\a\1\s\rpcs3\Emu\RSX\VK\VKRenderTargets.h:81[:10], in function as_rtt)```

@nitroos-ai
Copy link

It all began here #6357

@kd-11 kd-11 self-assigned this Dec 6, 2021
@AniLeo AniLeo changed the title Retro/Grade - [NPUB30280] messed up graphics on Vulkan and Opengl Regression: Retro/Grade messed up graphics on Vulkan and OpenGL (#6357) Dec 6, 2021
@kd-11
Copy link
Contributor

kd-11 commented Dec 6, 2021

Still an issue, graphics just output garbage on VK and OGL. tried multiple settings and nothing helped. Relaunching game can output different graphics so don't mislead yourself into thinking one setting helped. image No RSX capture because it kept crashing e.g with:

(in file D:\a\1\s\rpcs3\Emu\RSX\VK\VKRenderTargets.h:81[:10], in function as_rtt)```

This is correct output, just needs the tiled DMA patches I have on my local. Hopefully I'll have them cleaned up before too long.

@Triticum0
Copy link

Note: similar issue happens with mercury hg when RCB is enabled. so tited DMA patches will be the needed for that game to be moved to playable.
https://imgur.com/a/vqk4OLr

@Triticum0
Copy link

@AniLeo This needs to be reopened as it is the same #6609

@kd-11
Copy link
Contributor

kd-11 commented Dec 24, 2023

I checked this with RSX detiling enabled (and CPU blit) and the logos and menu now are mostly correct. However, the detiling is not kicking in for some situations when it absolutely should, the same issue observed in some games like NFS Rivals.

@kd-11
Copy link
Contributor

kd-11 commented Dec 24, 2023

Found it. Unfortunately it's messy. Blit engine writes to texture cache surfaces then RCB ignores them when loading memory leading to the loss (CPU blit off). When CPU blit is ON, the same fails because the CPU path does not support tiling.

@kd-11
Copy link
Contributor

kd-11 commented Dec 24, 2023

Fixed by #14934 when using CPU blit. The full fix for GPU-only blit is to unify texture and surface cache needs months of work and is a known long-term goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants