Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL/VK: ReSharper findings #10095

Merged
merged 4 commits into from
Apr 30, 2021
Merged

GL/VK: ReSharper findings #10095

merged 4 commits into from
Apr 30, 2021

Conversation

Megamouse
Copy link
Contributor

  • Fixes some ReSharper warnings (too lazy for const functions).
  • Found some unused enum values that might be the cause for some bugs (kd-11 maybe you can defuse them)

@Megamouse Megamouse requested a review from kd-11 April 11, 2021 13:58
@Megamouse Megamouse changed the title GL: ReSharper findings GL/VK: ReSharper findings Apr 11, 2021
@Megamouse Megamouse force-pushed the motrrr branch 2 times, most recently from 6717a2a to 3c03886 Compare April 13, 2021 19:58
@AniLeo AniLeo requested a review from kd-11 April 29, 2021 15:56
@Megamouse
Copy link
Contributor Author

removed useless changes

@Megamouse
Copy link
Contributor Author

removed some unused functions.
let me know if these were kept intentionally

kd-11
kd-11 approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Some removed function stubs may be useful at a later time, but I feel its ok to remove them for now.

@Megamouse Megamouse merged commit 71d58e3 into RPCS3:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Render: OpenGL Render: Vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Megamouse @kd-11