Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor savedata dialog changes #10187

Merged
merged 7 commits into from
Apr 29, 2021
Merged

Minor savedata dialog changes #10187

merged 7 commits into from
Apr 29, 2021

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 24, 2021 •
edited
Loading

  • Replace title with subtitle. The title is always the game name and is obsolete since the game should be running anyway.
  • Show the date of modification and the size of the savegame where the subtitle was shown before
  • Keep the focus on the last selected element if you declined the confirmation dialog

Old:

image

New:

image
image

Reference:

image

@Megamouse Megamouse added Savedata Anything that involves cellSaveData Overlay labels Apr 24, 2021
@Megamouse
Copy link
Contributor Author

Adjusted some wording and changed datetime to a more localized version (albeit less PS3-esque)

@Megamouse
Copy link
Contributor Author

Added size info. It may not be important but why not.

@Megamouse Megamouse force-pushed the users branch 3 times, most recently from 4843ef2 to a03fcf2 Compare April 25, 2021 19:35
@Megamouse Megamouse requested a review from kd-11 April 26, 2021 06:18
elad335
elad335 reviewed Apr 28, 2021
View reviewed changes
rpcs3/Emu/Cell/Modules/cellSaveData.cpp Outdated
std::string SaveDataEntry::data_size() const
{
std::string metric = "KB";
u64 sz = static_cast<u64>(std::ceil(size / 1000.0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils::aligned_div is what you're looking for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Megamouse
cellSaveData: keep focus after confirmation cancel
e9dc905 
It was very annoying to be thrown to beginning of the list after cancelling the confirmation.
@Megamouse
save-overlays: change list entry contents.
468bb49 
There's no need to tell the user that the entry is for game xy, they are already playing that game.
On a real PS3 only the subtitle and the date are displayed.
@Megamouse
save-overlays: add localization
22fe7e8
@Megamouse
save-overlays: add entry size info
e12058d
@Megamouse
user-overlays: add sanity check for enter button
183be04
@Megamouse
overlays: implement text_align::right
7ff5e1e
@Megamouse Megamouse merged commit d331ff3 into RPCS3:master Apr 29, 2021
@Megamouse Megamouse deleted the users branch April 30, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elad335 elad335 elad335 left review comments

@kd-11 kd-11 Awaiting requested review from kd-11

Assignees
No one assigned
Labels
Overlay Savedata Anything that involves cellSaveData
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Megamouse @elad335