Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: Refactor render target code #10194

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Apr 25, 2021

Base commit for a longer sequence of completed works

Copy link
Contributor

@Megamouse Megamouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how much of the code is copy pasta (don't wanna review copy pasta (at least as far as I can review the GPU code))

rpcs3/Emu/RSX/VK/VKRenderTargets.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/VK/VKRenderTargets.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/VK/VKRenderTargets.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/VK/VKRenderTargets.h Show resolved Hide resolved
@kd-11
Copy link
Contributor Author

kd-11 commented Apr 25, 2021

I wonder how much of the code is copy pasta (don't wanna review copy pasta (at least as far as I can review the GPU code))

All of it lol. It's just moving code from .h to .cpp

@Megamouse
Copy link
Contributor

then it should be fine after all the auto-indentation errors were resolved.
Maybe it is worth looking at includes in the header now.
If we're lucky we can move something to the cpp

@kd-11 kd-11 force-pushed the surface_fixes_slow branch from 19bb6a1 to 4e7cb12 Compare April 25, 2021 20:57
@kd-11
Copy link
Contributor Author

kd-11 commented Apr 25, 2021

That's still low prio for me, there's still a fairly severe leak happening somewhere between GPU and CPU, and I don't have it 100% patched. I've been picking at it for something like 100h by now and I keep finding bugs and patching them, but new problems just show up with every fix. Anyway, I'm sitting on quite a lot of code related to this stuff, I just want to start committing stuff slowly while I keep tracking down the leak. "Lucky" for me, the test scenario has random addresses each time, making debugging the problem super fun incredibly stressful.

@kd-11 kd-11 merged commit 9609767 into RPCS3:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants