Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: Refactor 7zlib #10222

Merged
merged 3 commits into from
May 1, 2021
Merged

BUILD: Refactor 7zlib #10222

merged 3 commits into from
May 1, 2021

Conversation

p01arst0rm
Copy link
Contributor

re-worked 7z files into their own directory structure

@p01arst0rm p01arst0rm changed the title Refactor 7zlib BUILD: Refactor 7zlib May 1, 2021
@p01arst0rm
Copy link
Contributor Author

cc @hcorion

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label May 1, 2021
@AniLeo AniLeo requested a review from hcorion May 1, 2021 13:43
@hcorion
Copy link
Member

hcorion commented May 1, 2021 •
edited
Loading

Why are all the 7z files marked as changed? Did you change their encoding or line endings or something?

@p01arst0rm
Copy link
Contributor Author

Why are all the 7z files marked as changed? Did you change their encoding or line endings or something?

shouldn't have, the files were only relocated. Maybe something weird with git?

@p01arst0rm
Copy link
Contributor Author

looks like git did something weird with line endings. fixed now :)

@Megamouse
Copy link
Contributor

you probably used cut and paste instead of git mv

hcorion
hcorion approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@hcorion hcorion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Megamouse Megamouse merged commit b62ac7a into RPCS3:master May 1, 2021
@p01arst0rm p01arst0rm deleted the refactor-7zlib branch May 1, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcorion hcorion hcorion approved these changes

Assignees
No one assigned
Labels
Build and CI Anything related to the build process and continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p01arst0rm @hcorion @Megamouse