Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: fix relative links to common_default* props #10225

Merged
merged 1 commit into from
May 1, 2021
Merged

BUILD: fix relative links to common_default* props #10225

merged 1 commit into from
May 1, 2021

Conversation

p01arst0rm
Copy link
Contributor

Links to common props files are relative; build files should avoid
relative links when/if at all possible.

@p01arst0rm
Copy link
Contributor Author

cc @hcorion

@p01arst0rm p01arst0rm changed the title fix relative links to common_default* props BUILD: fix relative links to common_default* props May 1, 2021
@hcorion
Copy link
Member

hcorion commented May 1, 2021

I don't really work with the vs solution files, so someone that does should check this out, but it makes sense to me.

@Megamouse
Copy link
Contributor

If it builds then it's probably fine

@Megamouse Megamouse merged commit ca0d38d into RPCS3:master May 1, 2021
@p01arst0rm p01arst0rm deleted the fix-relative-props branch May 1, 2021 16:46
@Megamouse Megamouse added Build and CI Anything related to the build process and continuous integration OS: Windows labels May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build and CI Anything related to the build process and continuous integration OS: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p01arst0rm @hcorion @Megamouse