Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Surface cache improvements #10257

Merged
merged 5 commits into from
May 9, 2021
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented May 8, 2021

Fixes a bunch of problems identified while looking into surface leak bug in Madden17. This doesn't contain all the fixes, but it introduces a subset of the patches that should be relatively safe:

  • Ignore blit to self commands. This seems to be a game bug, but I found it to be very unusual.
  • Separate transfer memory access into transfer_read and transfer_write. Writing has different coherency requirements than reading. This has consequences for performance and correctness at this stage.
  • Add some vulkan convenience features. Adds label insertion to renderdoc compatibility mode. Very convenient when tracing large files. Also allows vulkan present without waiting for this same purpose. Not directly useful to users but reduces iteration time when debugging complex bugs.

kd-11 added 4 commits May 8, 2021 19:35
- Transfer writes are expected to clobber surface cache contents. Do NOT reload from CPU memory for writes.
- TODO: During transfer write to surface cache objects, lock memory if it was unlocked to avoid silly problems.
- Labels make life so much easier
@kd-11 kd-11 merged commit a4f4b81 into RPCS3:master May 9, 2021
@Realmantik Realmantik mentioned this pull request Aug 27, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants