Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Move sys_rsx info to rsx::thread #10258

Merged
merged 2 commits into from
May 9, 2021
Merged

rsx: Move sys_rsx info to rsx::thread #10258

merged 2 commits into from
May 9, 2021

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented May 9, 2021

No description provided.

@Megamouse Megamouse added the RSX label May 9, 2021
kd-11
kd-11 approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred some encapsulation for this, to avoid dumping everything directly into rsx::thread; it's grown too large, any single class with over 3k loc is too large imo. But this is mostly my fault for not keeping the design in check so this is ok.

kd-11
kd-11 approved these changes May 9, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred some encapsulation for this, to avoid dumping everything directly into rsx::thread; it's grown too large, any single class with over 3k loc is too large imo. But this is mostly my fault for not keeping the design in check so this is ok.

@AniLeo AniLeo merged commit acded1e into RPCS3:master May 9, 2021
elad335 added a commit to elad335/rpcs3 that referenced this pull request May 9, 2021
@elad335
Revert "rsx: Move sys_rsx info to rsx::thread (RPCS3#10258)"
b7322f5 
This reverts commit acded1e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elad335 @kd-11 @AniLeo @Megamouse