Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset get_timebased_time at game boot #10744

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Offset get_timebased_time at game boot #10744

merged 2 commits into from
Aug 23, 2021

Conversation

Whatcookie
Copy link
Member

Adds an offset to get_timebased_time at the time of booting a game in the emulator. This can fix some issues that appeared at very high uptime, due to games misusing floating point math.

Problematic games used a pattern of:

read_clock();
convert_to_float();
calculate_delta();

instead of:

read_clock();
calculate_delta();
convert_to_float();

which caused problems with floating point rounding at extreme values of PC uptime.

fixes: #10632

Also fixes some issues with elder scrolls and fallout games

rpcs3/Emu/System.cpp Outdated Show resolved Hide resolved
- Avoids game bugs in the case where games convert the value read from the clock to a float before performing delta time calculations
@JimScript
Copy link

Thank You, Whatcookie, for fixing this odd problem for R&C:ToD. I didn't expect it would also improve the Gamebryo games, but more the merrier.

@AniLeo AniLeo merged commit d045193 into RPCS3:master Aug 23, 2021
@JimScript
Copy link

Yeah, it's fixed, This is on a system that has been active for over 8 days.

Before:
screenshot-2021_08_23_05_27_20

After:
screenshot-2021_08_23_05_54_46

And now the space levels don't softlock anymore:
screenshot-2021_08_23_05_55_40

@Satumariko
Copy link

nice to meet you.
From this version, the operation has been stable for some titles.
However, there is a problem with the title that was working normally until now.
An example is a title that has a very slow movie playback speed.
In particular, the movies of the works by KOEI are annihilated.

@Reltdeats
Copy link

Since this update, KILLZONE® [NPEA00418] cutscenes are accelerated. Tested on the latest update 0.0.18-12716 and still its not working properly.

@shiro6x

This comment was marked as off-topic.

@RPCS3 RPCS3 locked as off-topic and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ratchet & Clank Future games destablized with PC uptime
7 participants