Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Minor fixes #10975

Merged
merged 4 commits into from Oct 10, 2021
Merged

rsx: Minor fixes #10975

merged 4 commits into from Oct 10, 2021

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 9, 2021

  • Allow shader binding points to alias in the GL binding map. This is annoying, but old hw can have low amount of allowed resources (e.g only 8 SSBO slots)
  • Fix linear cubemap decoding when the face size is very small. Mistake from misinterpreted hwtest, I had swizzling enabled when I ran it many years ago, turns out behaviour is different depending on whether padding is enabled or not.

Fixes #10973
Fixes #9588
Fixes #10458
Fixes #8420

Probably fixes more, needs testing.

- While aliasing is easy to break, it allows outdated hw to run
- 128-byte boundary is not observed in linear tiling. Verified in hw.
@Realmantik
Copy link

This PR fixes shadows in Resident Evil Code Veronica X
fixed bug in resident evil veronica

@Xcedf
Copy link

Xcedf commented Oct 10, 2021

Confirm #9588 fixed

Uncharted 2
Before
12
After
13

Uncharted 3
Before
15
After
14

The Last of Us
Before
3
After
2

@Megamouse Megamouse added the RSX label Oct 10, 2021
@kd-11 kd-11 merged commit 479150b into RPCS3:master Oct 10, 2021
@Linear524
Copy link

Torchlight shadow cubemaps fixed :)
1625

Spotlight flashing lightbulb shadow cubemaps still broken:
1627
1628

(maybe the same fix is required for this type shadowmaps ?)

@kd-11
Copy link
Contributor Author

kd-11 commented Oct 11, 2021

RSX emulation is mostly LLE, so there is no cubemap fix per-se, just a fix in hardware emulation. These games aren't even using cubemaps for shadowing, just for address translation. Shadowing is done using virtual cubemaps - a thing that nvidia pushed back in the day due to hardware deficiencies in their products. As such, if you see issues in some other type of light, it will need a different fix. Just open a different ticket for that.

@Augusto7743
Copy link

That commit has fixed Teenage Mutant Ninja Turtles: Out of the Shadows [NPUB31217].
Have objects are rendered in screen never before displayed in RPCS3 previous version.
Details about are in #10993

@Augusto7743
Copy link

Pac-man Museum graphics fixed.

Now gameplay graphics are rendered.
01

02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants