rsx: Do not require ZCULL buffer binding to enable ZPASS counting #12432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ZPASS data is still accessible in unbuffered mode. The only thing that buffered ZCULL enables is something closer to early-Z where large blocks of pixels can be dicarded earlier. It is strictly a performance optimization and not required for ZPASS to work. - Update ZCULL stat calculations to take into account unbuffered Z
|
Fixes: #10869.
Deadpool: (Before/After Comparisons)Before - (RPCS3-0.0.23-13986): After - (PR): Transformers: Fall of Cybertron: (Before/After Comparisons)Before - (RPCS3-0.0.23-13986): After - (PR): Shaun White Skateboarding: (Before/After Comparisons)Before - (RPCS3-0.0.23-13986 - OpenGL): After - (PR - OpenGL): |
|
Fixes: #7741. Dante's Inferno:
(Before/After Comparisons)Before - (RPCS3-0.0.23-13986): After - (PR): |
|
How about Lucifer is he rendering in cutscenes? |
|
Still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing that buffered ZCULL enables is something closer to early-Z where large blocks of pixels can be dicarded earlier.
It is strictly a performance optimization and not required for ZPASS to work.
Fixes #10869
Fixes #7741