Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPCN v0.7 #12818

Merged
merged 1 commit into from
Oct 17, 2022
Merged

RPCN v0.7 #12818

merged 1 commit into from
Oct 17, 2022

Conversation

RipleyTom
Copy link
Contributor

Bump protocol version
Improve signaling RTT calculation for client
Implement score game data functions
Various sceNpScore fixes
Verify flatbuffer buffers
Use std::variant for transaction specific data

@RipleyTom RipleyTom marked this pull request as ready for review October 15, 2022 19:45
@pokeshark
Copy link

pokeshark commented Oct 15, 2022

What server could we use for testing?
Right now the protocol is mismatched with Official ("E rpcn: Server returned protocol version: 16, expected: 17") and RPCN Test Server throws error ("E rpcn: connect: Failed to connect to RPCN server!")

edit: works to connect now on test server

@RipleyTom
Copy link
Contributor Author

RipleyTom commented Oct 15, 2022

If you want to test I just setup the test server for it.
Technically don't expect more games to work though the following games needs retesting:

  • Sword Art Online: Lost Song
  • Naruto Shippuuden: Narutimate Storm Generation
  • Naruto Shippuden: Ultimate Ninja Storm Revolution
  • JoJo's Bizarre Adventure - All-Star Battle
  • Gladiator VS
  • Virtua Tennis 4
  • Armored Core V

Also games that use score data, and generally scoreboards should work now.

Also I'll probably update the main server on monday, I don't expect any major breakage from this update.

rpcs3/Emu/NP/np_requests.cpp Show resolved Hide resolved
rpcs3/Emu/NP/np_requests.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/NP/np_requests.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/NP/np_requests.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/NP/rpcn_client.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/NP/np_contexts.h Outdated Show resolved Hide resolved
rpcs3/Emu/NP/np_contexts.h Outdated Show resolved Hide resolved
rpcs3/Emu/NP/np_contexts.h Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/sceNp.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/sceNp.cpp Show resolved Hide resolved
Copy link
Contributor

@Megamouse Megamouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Risusama
Copy link

Tested Sword Art Online: Lost Song.

Normal "Quest lobbies" have been working (creatable and joinable) since RPCN 0.5 I think, and I was still able to create them as usual. (Did not get my friend to test joining to them yet.)

For the first time ever, I was also able to create normal "Duel lobby" without crashing, and was also able to exit from it cleanly (to my knowledge, at least).

In the Duel menu, pressing "Quick Matching" still crashes, at least when there are no existing Duel lobbies available. Not sure if it would crash when there is a Duel lobby available.

I'll report more information after I get my friend to test with me.
Included the log below.

RPCS3.zip

@jh0nny2k
Copy link

well tested SFxT again, difference from 0.6 we can now see lobbies again. same issue as the last time when trying to connect.

Bump protocol version
Improve signaling RTT calculation for client
Implement score game data functions
Various sceNpScore fixes
Verify flatbuffer buffers
Use std::variant for transaction specific data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants