Savestates/rsx/IO: Resume emulation on long START press, enable "Start Paused" by defaut #12881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
|
Implemented emulation unpausing using the START button, implementing part of #12539. This works very well with the new savestate pause state by default. |
Megamouse
reviewed
Oct 29, 2022
Megamouse
reviewed
Oct 29, 2022
Megamouse
reviewed
Oct 29, 2022
elad335
force-pushed
the
patch-6
branch
2 times, most recently
from
0e9907c to
8620355
Compare
elad335
changed the title
Megamouse
reviewed
Oct 29, 2022
elad335
force-pushed
the
patch-6
branch
3 times, most recently
from
7e9ff9c to
1d5563e
Compare
Megamouse
reviewed
Oct 29, 2022
elad335
force-pushed
the
patch-6
branch
8 times, most recently
from
463c2f8 to
33ba25a
Compare
elad335
changed the title
kd-11
reviewed
Oct 29, 2022
kd-11
reviewed
Oct 29, 2022
kd-11
reviewed
Oct 29, 2022
… manually Move some code in Emulator::Pause() so thread pausing is the first thing done by this function
kd-11
approved these changes
Oct 29, 2022
Megamouse
reviewed
Oct 29, 2022
Comment on lines
+442
to
+456
| rsx::overlays::queue_message(localized_string_id::EMULATION_RESUMING, 2'000'000); | ||
|
|
||
| m_resume_emulation_flag = true; | ||
|
|
||
| for (u32 i = 0; i < 40; i++) | ||
| { | ||
| if (!Emu.IsPaused()) | ||
| { | ||
| // Abort if emulation has been resumed by other means | ||
| m_resume_emulation_flag = false; | ||
| break; | ||
| } | ||
|
|
||
| thread_ctrl::wait_for(50'000); | ||
| rsx::set_native_ui_flip(); |
There was a problem hiding this comment.
I think these 3 magic numbers should be calculated from a single variable.
|
The message "Press and hold the START button to resume" shows up even when the emulator is frozen by a log.fatal() assertion. (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FPS_.29.57._.Vulkan._.0.0.24-64201fe4.Alpha._.patch-6._.local_build._.Persona.5.NPUB31848.2022-10-29.15-50-56.mp4
Implements part of #12539