Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Texture lod bias to UI #12905

Merged
merged 7 commits into from
Oct 30, 2022
Merged

Add Texture lod bias to UI #12905

merged 7 commits into from
Oct 30, 2022

Conversation

Darkhost1999
Copy link
Contributor

@Darkhost1999 Darkhost1999 commented Oct 30, 2022

I can move this setting where desired and would love reviews to help me improve.
This was added in an attempt to try and learn and grow. I failed at making this a slider and so I used a double spin box.
In my testing I find values of -3 to 3 to be really useful in most of my games I have. Improving the look of the game.
This setting appears to be dynamically applied and is to be set by the eye of the beholder to what they want.

Add Texture LOD Bias Addend to the UI. Figure out if I can use float and sliders or if I need to do something easier, Don't forget to set range and check if negatives are possible.
Implements TextureLODBias into the UI
@elad335
Copy link
Contributor

elad335 commented Oct 30, 2022

It probably doesn't need a silder anyway, so that's fine.

rpcs3/rpcs3qt/tooltips.h Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
Set default value correctly, remove unnecessary line
@Megamouse Megamouse merged commit 8d5a9dc into RPCS3:master Oct 30, 2022
@Darkhost1999 Darkhost1999 deleted the TextureLodBias branch October 30, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants