Game management improvements #13008
Merged
Game management improvements #13008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
games-gui
branch
3 times, most recently
from
e881c90 to
2a76753
Compare
Megamouse
reviewed
Dec 3, 2022
Megamouse
added
GUI
CLI
|
Ignore the 0 it's just for internal test. |
elad335
force-pushed
the
games-gui
branch
2 times, most recently
from
69b26e7 to
e579603
Compare
Megamouse
reviewed
Dec 3, 2022
Megamouse
reviewed
Dec 3, 2022
Megamouse
reviewed
Dec 3, 2022
elad335
force-pushed
the
games-gui
branch
8 times, most recently
from
a141ec8 to
b558672
Compare
elad335
force-pushed
the
games-gui
branch
5 times, most recently
from
005004a to
0c8940f
Compare
Megamouse
reviewed
Dec 4, 2022
Megamouse
reviewed
Dec 4, 2022
rpcs3/rpcs3qt/main_window.cpp
Outdated
| }; | ||
|
|
||
|
|
||
| for (const auto& [location_string, location, to_install] : installing_locations) |
There was a problem hiding this comment.
Use the struct here.
This notation shouldn't be used if a proper type exists
Megamouse
reviewed
Dec 4, 2022
rpcs3/Emu/System.h
Outdated
| @@ -280,6 +280,7 @@ class Emulator final | |||
|
|
|||
| void SetUsr(const std::string& user); | |||
|
|
|||
| static std::string GetBackgroundPicturePath(const std::string& sfo_dir, const std::string& title_id); | |||
There was a problem hiding this comment.
I don't think this is the correct function.
This one gets the background for the shader dialogs
Allowing to move of game directories without having to update the shortcut path. (as long as it is registered within RPCS3 UI).
elad335
force-pushed
the
games-gui
branch
2 times, most recently
from
49b91a7 to
3ab206a
Compare
Megamouse
reviewed
Dec 9, 2022
Comment on lines
+1016
to
+1024
| const QIcon icon = gui::utils::get_app_icon_from_path(rpcs3::utils::get_sfo_dir_from_game_path(boot_path + "/../../"), std_title_id); | ||
| QPixmap pix = icon.pixmap(icon.actualSize(QSize(1000, 1000))); | ||
| QByteArray bytes; | ||
| QBuffer buffer(&bytes); | ||
| buffer.open(QIODevice::ReadWrite); | ||
| pix.save(&buffer, "PNG"); | ||
| tmp_file.write(bytes.data(), bytes.size()); | ||
|
|
||
| std::string icon_path = sstr(tmp_file.fileName()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpcs3.exe --no-gui "%RPCS3_GAMEID%:BCES01584"rpcs3.exe --no-gui "%RPCS3_VFS%:dev_hdd0/game/NPUB30695/USRDIR/EBOOT.BIN"