Texture Dumper + RSX Draw Call Stepping #13042
Merged
+722
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
reviewed
Dec 10, 2022
rpcs3/Emu/RSX/rsx_methods.cpp
Outdated
| @@ -657,6 +657,13 @@ namespace rsx | |||
| { | |||
| rsxthr->in_begin_end = false; | |||
| } | |||
|
|
|||
| if (rsxthr->pause_on_draw.exchange(false)) | |||
There was a problem hiding this comment.
Maybe test pause_on_draw before exchange()?
Nekotekina
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
|
Reviews fixed. |
Nekotekina
approved these changes
Dec 10, 2022
|
No merge |
|
Resolved in pm. |
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
elad335
force-pushed
the
rsx-dumper
branch
2 times, most recently
from
a87e718 to
bf0df42
Compare
Megamouse
reviewed
Dec 10, 2022
Megamouse
reviewed
Dec 10, 2022
Also fix many bugs in textures display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep in mind that in order to view them correctly you need to step RSX into a draw call and may use Write Color Buffers in order to dump rendered images. (source textures can mostly be viewed fine without it though)
Also, RSX needs to be paused. (due to performance issues I disabled view when it's running)
If you want to dump rendered depth buffer "images" you need Write Depth Buffer enabled.
https://cdn.discordapp.com/attachments/272875751773306881/1051084619933552670/image.png
Fixes #1659